Skip to content

[mlir][spirv] Add convergent attribute to builtin #122131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[mlir][spirv] Add convergent attribute to builtin #122131

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a048616
[mlir][spirv] Add convergent attribute to builtin
sommerlukas Jan 8, 2025
81f5a79
Address PR feedback
sommerlukas Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,8 +1028,7 @@ class ReturnValuePattern : public SPIRVToLLVMConversion<spirv::ReturnValueOp> {
static LLVM::LLVMFuncOp lookupOrCreateSPIRVFn(Operation *symbolTable,
StringRef name,
ArrayRef<Type> paramTypes,
Type resultType,
bool convergent = true) {
Type resultType) {
auto func = dyn_cast_or_null<LLVM::LLVMFuncOp>(
SymbolTable::lookupSymbolIn(symbolTable, name));
if (func)
Expand All @@ -1040,7 +1039,7 @@ static LLVM::LLVMFuncOp lookupOrCreateSPIRVFn(Operation *symbolTable,
symbolTable->getLoc(), name,
LLVM::LLVMFunctionType::get(resultType, paramTypes));
func.setCConv(LLVM::cconv::CConv::SPIR_FUNC);
func.setConvergent(convergent);
func.setConvergent(true);
func.setNoUnwind(true);
func.setWillReturn(true);
return func;
Expand Down Expand Up @@ -1253,8 +1252,8 @@ class GroupReducePattern : public SPIRVToLLVMConversion<ReduceOp> {
Operation *symbolTable =
op->template getParentWithTrait<OpTrait::SymbolTable>();

LLVM::LLVMFuncOp func = lookupOrCreateSPIRVFn(
symbolTable, funcName, paramTypes, retTy, !NonUniform);
LLVM::LLVMFuncOp func =
lookupOrCreateSPIRVFn(symbolTable, funcName, paramTypes, retTy);

Location loc = op.getLoc();
Value scope = rewriter.create<LLVM::ConstantOp>(
Expand Down
Loading
Loading