Skip to content

[SelectionDAG] Use SDNode::op_iterator instead of SDNodeIterator. NFC #122147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[SelectionDAG] Use SDNode::op_iterator instead of SDNodeIterator. NFC #122147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ca7cf
[SelectionDAG] Use SDNode::op_iterator instead of SDNodeIterator. NFC
topperc Jan 8, 2025
69b80e3
fixup! Use Op->ops(). Use llvm::any_of.
topperc Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2985,13 +2985,11 @@ bool TargetLowering::SimplifyDemandedBits(
if (!isTargetCanonicalConstantNode(Op) &&
DemandedBits.isSubsetOf(Known.Zero | Known.One)) {
// Avoid folding to a constant if any OpaqueConstant is involved.
const SDNode *N = Op.getNode();
for (SDNode *Op :
llvm::make_range(SDNodeIterator::begin(N), SDNodeIterator::end(N))) {
if (auto *C = dyn_cast<ConstantSDNode>(Op))
if (C->isOpaque())
return false;
}
if (llvm::any_of(Op->ops(), [](SDValue V) {
auto *C = dyn_cast<ConstantSDNode>(V);
return C && C->isOpaque();
}))
return false;
if (VT.isInteger())
return TLO.CombineTo(Op, TLO.DAG.getConstant(Known.One, dl, VT));
if (VT.isFloatingPoint())
Expand Down
Loading