[InstCombine] Further relax one-use constraint in foldICmpBinOp
#122266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
goldsteinn
reviewed
Jan 9, 2025
|
|
||
| const APInt *C; | ||
| if (match(BO0->getOperand(1), m_APInt(C)) && !C->isZero() && | ||
| if (BO0->hasOneUse() && BO1->hasOneUse() && |
Member
Author
There was a problem hiding this comment.
No. We create two and instructions and one icmp here. See the test eq_mul_constants_with_tz_extra_use1.
Contributor
There was a problem hiding this comment.
Yeah fair enough, just this case is not relaxing the constraint, its tightening it.
Member
Author
There was a problem hiding this comment.
Yes. I already pointed out this in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses regressions introduced by #121892.
It also fixes a multi-use issue introduced by #76384 (tested in
eq_mul_constants_with_tz_extra_use1).