Skip to content

[AMDGPU] Fix spurious NoAlias results #122309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2025
Merged

[AMDGPU] Fix spurious NoAlias results #122309

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d057782
[AMDGPU] Fix spurious NoAlias results
frasercrmck Jan 9, 2025
a6e37b2
remove attributes
frasercrmck Jan 9, 2025
57b2448
used identifiedobject
frasercrmck Jan 13, 2025
e18b903
swap checks
frasercrmck Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ AliasResult AMDGPUAAResult::alias(const MemoryLocation &LocA,
// variables in shared or private address space.
const auto *ObjB =
getUnderlyingObject(B.Ptr->stripPointerCastsForAliasAnalysis());
return (ObjA == ObjB) ? AliasResult::MustAlias : AliasResult::NoAlias;
return isIdentifiedObject(ObjB) && ObjA != ObjB ? AliasResult::NoAlias
: AliasResult::MayAlias;
}
default:
// TODO: In the regular function, if that local variable in the
Expand Down
6 changes: 3 additions & 3 deletions llvm/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,9 @@ define void @test_9_9(ptr addrspace(9) %p, ptr addrspace(9) %p1) {
}

; CHECK-LABEL: Function: test_kernel_arg_local_ptr
; CHECK: MayAlias: i32 addrspace(3)* %arg, i32 addrspace(3)* %arg1
; CHECK: MustAlias: i32 addrspace(3)* %arg, i32* %arg2
; CHECK: MustAlias: i32 addrspace(3)* %arg1, i32* %arg2
; CHECK: MayAlias: i32 addrspace(3)* %arg, i32 addrspace(3)* %arg1
; CHECK: MayAlias: i32 addrspace(3)* %arg, i32* %arg2
; CHECK: MayAlias: i32 addrspace(3)* %arg1, i32* %arg2
define amdgpu_kernel void @test_kernel_arg_local_ptr(ptr addrspace(3) %arg) {
entry:
%load1 = load i32, ptr addrspace(3) %arg, align 4
Expand Down
Loading