[OpenMP][FIX] Adjust test to be non-flaky #122331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test runs asynchronous kernels and depending on the timing the output is slightly different. We now only check for the common parts of the output.
Member
|
@llvm/pr-subscribers-offload Author: Johannes Doerfert (jdoerfert) ChangesThe test runs asynchronous kernels and depending on the timing the output is slightly different. We now only check for the common parts of the output. Full diff: https://github.com/llvm/llvm-project/pull/122331.diff 1 Files Affected:
diff --git a/offload/test/sanitizer/kernel_crash_async.c b/offload/test/sanitizer/kernel_crash_async.c
index ee22ba504018be..d51418f8178897 100644
--- a/offload/test/sanitizer/kernel_crash_async.c
+++ b/offload/test/sanitizer/kernel_crash_async.c
@@ -36,4 +36,4 @@ int main(void) {
// TRACE: Kernel {{.*}} (__omp_offloading_{{.*}}_main_l29)
// TRACE: launchKernel
//
-// CHECK: Kernel {{[0-9]}}: {{.*}} (__omp_offloading_{{.*}}_main_l29)
+// CHECK: Kernel {{.*}} (__omp_offloading_{{.*}}_main_l29)
|
jhuber6
approved these changes
Jan 9, 2025
BaiXilin
pushed a commit
to BaiXilin/llvm-project
that referenced
this pull request
Jan 12, 2025
The test runs asynchronous kernels and depending on the timing the output is slightly different. We now only check for the common parts of the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runs asynchronous kernels and depending on the timing the output is slightly different. We now only check for the common parts of the output.