[libc++][NFC] Use uint32_t instead of __uint32_t on Apple #122356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesWe had a 15 year old occurence of __uint32_t, likely from a time when uint32_t was not available everywhere. Full diff: https://github.com/llvm/llvm-project/pull/122356.diff 1 Files Affected:
diff --git a/libcxx/include/__locale b/libcxx/include/__locale
index 94dc8a08437bfe..8bedd113fb5910 100644
--- a/libcxx/include/__locale
+++ b/libcxx/include/__locale
@@ -348,7 +348,7 @@ public:
# define _LIBCPP_CTYPE_MASK_IS_COMPOSITE_ALPHA
#elif defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__)
# ifdef __APPLE__
- typedef __uint32_t mask;
+ typedef uint32_t mask;
# elif defined(__FreeBSD__)
typedef unsigned long mask;
# elif defined(__NetBSD__)
|
philnik777
approved these changes
Jan 9, 2025
frederick-vs-ja
approved these changes
Jan 9, 2025
We had a 15 year old occurence of __uint32_t, likely from a time when uint32_t was not available everywhere.
ldionne
force-pushed
the
review/use-uint32_t-on-apple
branch
from
bd50d6b to
a9ed4b6
Compare
kazutakahirata
pushed a commit
to kazutakahirata/llvm-project
that referenced
this pull request
Jan 13, 2025
We had a 15 year old occurence of __uint32_t, likely from a time when uint32_t was not available everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a 15 year old occurence of __uint32_t, likely from a time when uint32_t was not available everywhere.