-
Notifications
You must be signed in to change notification settings - Fork 14.7k
[DXIL] Adding support to RootSignatureFlags in obj2yaml #122396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
8adb678
ba78f21
0a54559
557075f
e0d3dcd
80587dd
be3764d
7582ca6
6aaa0a5
916b2f1
d9bce0a
e7676ed
a0cee57
1e7a1fe
0ed658a
932062e
628937c
1378c9f
e3206c9
f93d42d
25e3f37
751cbdc
44532d6
ca21878
987901c
0fbe900
b771aea
74f7226
69f581a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,10 @@ DXContainerYAML::ShaderHash::ShaderHash(const dxbc::ShaderHash &Data) | |
memcpy(Digest.data(), &Data.Digest[0], 16); | ||
} | ||
|
||
DXContainerYAML::RootSignatureDesc::RootSignatureDesc(const dxbc::RootSignatureDesc &Data) | ||
: Version(Data.Version), Flags(Data.Flags) { | ||
} | ||
|
||
DXContainerYAML::PSVInfo::PSVInfo() : Version(0) { | ||
memset(&Info, 0, sizeof(Info)); | ||
} | ||
|
@@ -188,6 +192,12 @@ void MappingTraits<DXContainerYAML::Signature>::mapping( | |
IO.mapRequired("Parameters", S.Parameters); | ||
} | ||
|
||
void MappingTraits<DXContainerYAML::RootSignatureDesc>::mapping( | ||
IO &IO, DXContainerYAML::RootSignatureDesc &S) { | ||
IO.mapRequired("Version", S.Version); | ||
IO.mapRequired("Flags", S.Flags); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You might look at how we did the In going that route the one thing I would probably do differently is making each flag "optional" rather than required in the yaml with a default value as false. That will make the printing more concise. |
||
} | ||
|
||
void MappingTraits<DXContainerYAML::Part>::mapping(IO &IO, | ||
DXContainerYAML::Part &P) { | ||
IO.mapRequired("Name", P.Name); | ||
|
@@ -197,6 +207,7 @@ void MappingTraits<DXContainerYAML::Part>::mapping(IO &IO, | |
IO.mapOptional("Hash", P.Hash); | ||
IO.mapOptional("PSVInfo", P.Info); | ||
IO.mapOptional("Signature", P.Signature); | ||
IO.mapOptional("RootSignature", P.RootSignature); | ||
} | ||
|
||
void MappingTraits<DXContainerYAML::Object>::mapping( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.