Skip to content

[AMDGPU] Provide default value in get intrinsic param type #122448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[AMDGPU] Provide default value in get intrinsic param type #122448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
876066e
[AMDGPU] Provide default value in get intrinsic param
Jan 10, 2025
7cf7c74
You shall not pass here, null T.
Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 34 additions & 16 deletions llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,23 +929,38 @@ AMDGPULibFuncBase::Param AMDGPULibFuncBase::Param::getFromTy(Type *Ty,
return P;
}

static Type* getIntrinsicParamType(
LLVMContext& C,
const AMDGPULibFunc::Param& P,
bool useAddrSpace) {
Type* T = nullptr;
static Type *getIntrinsicParamType(LLVMContext &C,
const AMDGPULibFunc::Param &P,
bool UseAddrSpace) {
Type *T = nullptr;
switch (P.ArgType) {
default:
return nullptr;
case AMDGPULibFunc::U8:
case AMDGPULibFunc::I8: T = Type::getInt8Ty(C); break;
case AMDGPULibFunc::I8:
T = Type::getInt8Ty(C);
break;
case AMDGPULibFunc::U16:
case AMDGPULibFunc::I16: T = Type::getInt16Ty(C); break;
case AMDGPULibFunc::I16:
T = Type::getInt16Ty(C);
break;
case AMDGPULibFunc::U32:
case AMDGPULibFunc::I32: T = Type::getInt32Ty(C); break;
case AMDGPULibFunc::I32:
T = Type::getInt32Ty(C);
break;
case AMDGPULibFunc::U64:
case AMDGPULibFunc::I64: T = Type::getInt64Ty(C); break;
case AMDGPULibFunc::F16: T = Type::getHalfTy(C); break;
case AMDGPULibFunc::F32: T = Type::getFloatTy(C); break;
case AMDGPULibFunc::F64: T = Type::getDoubleTy(C); break;
case AMDGPULibFunc::I64:
T = Type::getInt64Ty(C);
break;
case AMDGPULibFunc::F16:
T = Type::getHalfTy(C);
break;
case AMDGPULibFunc::F32:
T = Type::getFloatTy(C);
break;
case AMDGPULibFunc::F64:
T = Type::getDoubleTy(C);
break;

case AMDGPULibFunc::IMG1DA:
case AMDGPULibFunc::IMG1DB:
Expand All @@ -972,7 +987,7 @@ static Type* getIntrinsicParamType(
T = FixedVectorType::get(T, P.VectorSize);
if (P.PtrKind != AMDGPULibFunc::BYVALUE)
T = PointerType::get(
C, useAddrSpace ? ((P.PtrKind & AMDGPULibFunc::ADDR_SPACE) - 1) : 0);
C, UseAddrSpace ? ((P.PtrKind & AMDGPULibFunc::ADDR_SPACE) - 1) : 0);
return T;
}

Expand All @@ -989,9 +1004,11 @@ FunctionType *AMDGPUMangledLibFunc::getFunctionType(const Module &M) const {
Args.push_back(ParamTy);
}

return FunctionType::get(
getIntrinsicParamType(C, getRetType(FuncId, Leads), true),
Args, false);
Type *RetTy = getIntrinsicParamType(C, getRetType(FuncId, Leads), true);
if (!RetTy)
return nullptr;

return FunctionType::get(RetTy, Args, false);
}

unsigned AMDGPUMangledLibFunc::getNumArgs() const {
Expand Down Expand Up @@ -1080,6 +1097,7 @@ FunctionCallee AMDGPULibFunc::getOrInsertFunction(Module *M,
}

FunctionType *FuncTy = fInfo.getFunctionType(*M);
assert(FuncTy);

bool hasPtr = false;
for (FunctionType::param_iterator
Expand Down
Loading