Skip to content

[MLIR] Enable inlining for private symbols #122572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2025
Merged

[MLIR] Enable inlining for private symbols #122572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mlir/lib/Dialect/LLVMIR/Transforms/InlinerInterfaceImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,8 +663,6 @@ struct LLVMInlinerInterface : public DialectInlinerInterface {

bool isLegalToInline(Operation *call, Operation *callable,
bool wouldBeCloned) const final {
if (!wouldBeCloned)
return false;
if (!isa<LLVM::CallOp>(call)) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline: call is not an '"
<< LLVM::CallOp::getOperationName() << "' op\n");
Expand Down
13 changes: 13 additions & 0 deletions mlir/test/Dialect/LLVMIR/inlining.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,3 +663,16 @@ llvm.func @caller() {
llvm.call @vararg_intrinrics() : () -> ()
llvm.return
}

// -----

llvm.func @private_func(%a : i32) -> i32 attributes {sym_visibility = "private"} {
llvm.return %a : i32
}

// CHECK-LABEL: func @caller
llvm.func @caller(%x : i32) -> i32 {
// CHECK-NOT: llvm.call @private_func
%z = llvm.call @private_func(%x) : (i32) -> (i32)
llvm.return %z : i32
}
Loading