Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1/2
I am planning to add some optimization remarks to the
PartiallyInlineLibCallspass.However, since this pass does not emit any optimization remarks yet, I have to add the "infrastructure" for that first, which is what this PR is about.
Questions/points of uncertainty for reviewers:
OptimizationRemarkEmitterobject from theOptimizationRemarkEmitteranalysis pass. This seems to be used in other optimization passes for this purpose, but I cannot claim that I understand it.OptimizationRemarkEmitterobject brings inLazy Branch Probability AnalysisandLazy Block Frequency Analysisas a dependency. I had to change some optimization pass ordering tests that were failing due to this. Please confirm that this is an inconsequential change.