Skip to content

Conversation

@TiborGY
Copy link
Contributor

@TiborGY TiborGY commented Jan 12, 2025

PR 1/2
I am planning to add some optimization remarks to the PartiallyInlineLibCalls pass.
However, since this pass does not emit any optimization remarks yet, I have to add the "infrastructure" for that first, which is what this PR is about.

Questions/points of uncertainty for reviewers:

  1. I am getting the pointer for the OptimizationRemarkEmitter object from the OptimizationRemarkEmitter analysis pass. This seems to be used in other optimization passes for this purpose, but I cannot claim that I understand it.
  2. It looks like getting an OptimizationRemarkEmitter object brings in Lazy Branch Probability Analysis and Lazy Block Frequency Analysis as a dependency. I had to change some optimization pass ordering tests that were failing due to this. Please confirm that this is an inconsequential change.

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@TiborGY TiborGY force-pushed the main branch 4 times, most recently from 68df5f6 to 6457396 Compare January 12, 2025 21:34
@TiborGY TiborGY changed the title [WIP] Add missed optimization remark if LLVM inserts a branch when optimizing sqrt calls [WIP] Add infrastructure for emitting optimization remarks from PartiallyInlineLibCalls Jan 12, 2025
@TiborGY TiborGY changed the title [WIP] Add infrastructure for emitting optimization remarks from PartiallyInlineLibCalls [PartiallyInlineLibCalls] Add infrastructure for emitting optimization remarks from PartiallyInlineLibCalls Jan 12, 2025
@TiborGY TiborGY closed this Jan 12, 2025
@TiborGY TiborGY changed the title [PartiallyInlineLibCalls] Add infrastructure for emitting optimization remarks from PartiallyInlineLibCalls [branch abandoned, ignore] Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant