Skip to content

Conversation

@perry-ca
Copy link
Contributor

The header <features.h> is a system header. It's not part of the headers in __cxx03.

@perry-ca perry-ca requested a review from a team as a code owner January 13, 2025 18:36
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 13, 2025
@perry-ca perry-ca requested review from abhina-sree and zibi2 January 13, 2025 18:38
@perry-ca perry-ca self-assigned this Jan 13, 2025
Copy link
Contributor

@abhina-sree abhina-sree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llvmbot
Copy link
Member

llvmbot commented Jan 13, 2025

@llvm/pr-subscribers-libcxx

Author: Sean Perry (perry-ca)

Changes

The header <features.h> is a system header. It's not part of the headers in __cxx03.


Full diff: https://github.com/llvm/llvm-project/pull/122763.diff

1 Files Affected:

  • (modified) libcxx/include/__cxx03/__config (+1-1)
diff --git a/libcxx/include/__cxx03/__config b/libcxx/include/__cxx03/__config
index 3e8f181664c975..880d14a50a0525 100644
--- a/libcxx/include/__cxx03/__config
+++ b/libcxx/include/__cxx03/__config
@@ -230,7 +230,7 @@ _LIBCPP_HARDENING_MODE_DEBUG
 #  endif
 
 #  if defined(__MVS__)
-#    include <__cxx03/features.h> // for __NATIVE_ASCII_F
+#    include <features.h> // for __NATIVE_ASCII_F
 #  endif
 
 #  if defined(_WIN32)

@ldionne ldionne merged commit b3ad84b into llvm:main Jan 13, 2025
37 of 44 checks passed
kazutakahirata pushed a commit to kazutakahirata/llvm-project that referenced this pull request Jan 13, 2025
The header <features.h> is a system header. It's not part of the headers
in __cxx03.
@perry-ca perry-ca deleted the perry/cxx03-features.h branch January 17, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants