Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a short comment what you're testing?

// <fstream>

// XFAIL: target={{.*}}-windows{{.*}}

#include <fstream>
#include <iostream>
#include <cassert>
#include <vector>

#include "assert_macros.h"
#include "platform_support.h"
#include "test_macros.h"

void test_tellg(std::streamoff total_size) {
std::vector<char> data(8192);
for (std::size_t i = 0; i < data.size(); ++i)
data[i] = static_cast<char>(i % (1 << 8 * sizeof(char)));
std::string p = get_temp_file_name();
{
std::ofstream ofs;
ofs.open(p, std::ios::out | std::ios::binary);
assert(ofs.is_open());
for (std::streamoff size = 0; size < total_size;) {
std::size_t n = std::min(static_cast<std::streamoff>(data.size()), total_size - size);
ofs.write(data.data(), n);
size += n;
}
assert(!ofs.fail());
ofs.close();
}
{
std::ifstream ifs;
ifs.open(p, std::ios::binary);
assert(ifs.is_open());
std::streamoff in_off = ifs.tellg();
TEST_REQUIRE(in_off == 0, [&] { test_eprintf("in_off = %ld\n", in_off); });
ifs.seekg(total_size - 20, std::ios::beg);
in_off = ifs.tellg();
TEST_REQUIRE(in_off == total_size - 20, [&] {
test_eprintf("ref = %zu, in_off = %ld\n", total_size - 20, in_off);
});
ifs.seekg(10, std::ios::cur);
in_off = ifs.tellg();
TEST_REQUIRE(in_off == total_size - 10, [&] {
test_eprintf("ref = %zu, in_off = %ld\n", total_size - 10, in_off);
});
ifs.seekg(0, std::ios::end);
in_off = ifs.tellg();
TEST_REQUIRE(in_off == total_size, [&] { test_eprintf("ref = %zu, in_off = %ld\n", total_size, in_off); });
}
std::remove(p.c_str());
}

int main(int, char**) {
// TODO: What if std::streamoff is only 32 bit, which may be the case on
// some platforms?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just static_assert(sizeof(std::streamoff) > 4) and almost certainly // UNSUPPORTED: 32-bit-pointer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, such a static assert probably would make sense.

No, 32 bit platforms are fine, you can clearly operate on files larger than 4 GB even if running a 32 bit process, and libc++ does define std::streamoff as a 64 bit data type even in 32 bit mode - at least on 32 bit Windows where I've tested this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static_assert() is making the tests fail in C++03 mode:

# .---command stderr------------
  # | /__w/llvm-project/llvm-project/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp:68:3: error: 'static_assert' with no message is a C++17 extension [-Werror,-Wc++17-extensions]
  # |    68 |   static_assert(sizeof(std::streamoff) > 4);
  # |       |   ^
  # | /__w/llvm-project/llvm-project/build/generic-cxx03/libcxx/test-suite-install/include/c++/v1/__config:307:58: note: expanded from macro 'static_assert'
  # |   307 | #    define static_assert(...) _Static_assert(__VA_ARGS__)
  # |       |                                                          ^
  # | 1 error generated.
  # `-----------------------------

Any suggestion on which way to go about it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make it static_assert(condition, ""). That's what we usually do pre-C++17.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see - doh. Thank you!

test_tellg(0x100000042ULL);
return 0;
}
Loading