Skip to content

Conversation

@AlexVlx
Copy link
Contributor

@AlexVlx AlexVlx commented Jan 15, 2025

Remove spurious --spirv-allow-extra-diexpressions flag from the translator invocation, as it's already implied by using nonsemantic-shader-200.

…nslator invocation, as it's already implied by using `nonsemantic-shader-200`.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Jan 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 15, 2025

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-driver

Author: Alex Voicu (AlexVlx)

Changes

Remove spurious --spirv-allow-extra-diexpressions flag from the translator invocation, as it's already implied by using nonsemantic-shader-200.


Full diff: https://github.com/llvm/llvm-project/pull/122995.diff

1 Files Affected:

  • (modified) clang/lib/Driver/ToolChains/HIPAMD.cpp (-1)
diff --git a/clang/lib/Driver/ToolChains/HIPAMD.cpp b/clang/lib/Driver/ToolChains/HIPAMD.cpp
index 42c48f6c9b7743..ccee065b590647 100644
--- a/clang/lib/Driver/ToolChains/HIPAMD.cpp
+++ b/clang/lib/Driver/ToolChains/HIPAMD.cpp
@@ -176,7 +176,6 @@ void AMDGCN::Linker::constructLinkAndEmitSpirvCommand(
   llvm::opt::ArgStringList TrArgs{
       "--spirv-max-version=1.6",
       "--spirv-ext=+all",
-      "--spirv-allow-extra-diexpressions",
       "--spirv-allow-unknown-intrinsics",
       "--spirv-lower-const-expr",
       "--spirv-preserve-auxdata",

@AlexVlx AlexVlx removed the clang Clang issues not falling into any other category label Jan 15, 2025
@AlexVlx AlexVlx requested review from MrSidims and yxsamliu January 15, 2025 01:15
@AlexVlx AlexVlx merged commit c805df6 into llvm:main Jan 16, 2025
11 checks passed
@AlexVlx AlexVlx deleted the remove_spurious_flag_amdgcnspirv branch January 16, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl'

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants