Skip to content

[ctxprof] add toYAML conversion to llvm-ctxprof-utils #123131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

[ctxprof] add toYAML conversion to llvm-ctxprof-utils #123131

merged 1 commit into from
Jan 16, 2025

Conversation

@mtrofin
Copy link
Member

@mtrofin mtrofin commented Jan 15, 2025 •
edited
Loading

Also modified test file to match "toYaml" formatting.

@mtrofin mtrofin mentioned this pull request Jan 15, 2025
Merged
@mtrofin Graphite App
Copy link
Member Author

mtrofin commented Jan 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mtrofin mtrofin changed the title [ctxprof] add conversion to yaml to llvm-ctxprof-utils [ctxprof] add "toYaml" conversion to llvm-ctxprof-utils Jan 15, 2025
@mtrofin mtrofin changed the title [ctxprof] add "toYaml" conversion to llvm-ctxprof-utils [ctxprof] add toYAML conversion to llvm-ctxprof-utils Jan 15, 2025
@mtrofin mtrofin marked this pull request as ready for review January 15, 2025 22:31
kazutakahirata
kazutakahirata approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrofin Graphite App
Copy link
Member Author

mtrofin commented Jan 16, 2025 •
edited
Loading

Merge activity

  • Jan 15, 7:47 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 15, 7:50 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 15, 7:53 PM EST: A user merged this pull request with Graphite.

@mtrofin mtrofin force-pushed the users/mtrofin/01-15-_ctxprof_use_yaml_for_serialization_for_testing_ branch from 40cfe22 to a4053ba Compare January 16, 2025 00:48
Base automatically changed from users/mtrofin/01-15-_ctxprof_use_yaml_for_serialization_for_testing_ to main January 16, 2025 00:50
@mtrofin mtrofin force-pushed the users/mtrofin/01-15-_ctxprof_add_conversion_to_yaml_to_llvm-ctxprof-utils branch from c8e600b to 5b05dd2 Compare January 16, 2025 00:50
@mtrofin mtrofin merged commit c70f246 into main Jan 16, 2025
5 of 7 checks passed
@mtrofin mtrofin deleted the users/mtrofin/01-15-_ctxprof_add_conversion_to_yaml_to_llvm-ctxprof-utils branch January 16, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazutakahirata kazutakahirata kazutakahirata approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtrofin @kazutakahirata