Skip to content

[bazel] Remove //clang:basic_internal_headers target (NFC) #123230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slackito merged 1 commit into from
Jan 17, 2025
Merged

[bazel] Remove //clang:basic_internal_headers target (NFC) #123230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions utils/bazel/llvm-project-overlay/clang/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,19 +666,6 @@ py_binary(
main = "utils/bundle_resources.py",
)

# A hacky library to expose some internal headers of the `basic` library to its
# own implementation source files using a stripped include prefix rather than
# file-relative-inclusion. This is inherently non-modular as these headers will
# be repeated in the sources below for file-relative-inclusion.
cc_library(
name = "basic_internal_headers",
hdrs = glob([
"lib/Basic/*.h",
]),
features = ["-header_modules"],
strip_include_prefix = "lib/Basic",
)

cc_library(
name = "basic",
srcs = [
Expand All @@ -696,6 +683,7 @@ cc_library(
copts = [
"-DHAVE_VCS_VERSION_INC",
"$(STACK_FRAME_UNLIMITED)",
"-I$(WORKSPACE_ROOT)/clang/lib/Basic",
],
includes = ["include"],
textual_hdrs = [
Expand Down Expand Up @@ -729,6 +717,7 @@ cc_library(
] + glob([
"include/clang/Basic/*.def",
]),
toolchains = [":workspace_root"],
deps = [
":basic_arm_cde_gen",
":basic_arm_fp16_inc_gen",
Expand All @@ -748,7 +737,6 @@ cc_library(
":basic_builtins_spirv_gen",
":basic_builtins_x86_64_gen",
":basic_builtins_x86_gen",
":basic_internal_headers",
":basic_riscv_sifive_vector_builtins_gen",
":basic_riscv_vector_builtin_cg_gen",
":basic_riscv_vector_builtins_gen",
Expand Down
Loading