-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[IR] Replace of PointerType::get(Type) with opaque version (NFC) #123617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
9c26763
c07e7ac
60c0e42
f2057f1
41fdaba
83063c6
607dbd7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,7 +47,7 @@ void Type::dump() { | |
|
|
||
| PointerType *PointerType::get(Type *ElementType, unsigned AddressSpace) { | ||
| return cast<PointerType>(ElementType->getContext().getType( | ||
| llvm::PointerType::get(ElementType->LLVMTy, AddressSpace))); | ||
| llvm::PointerType::get(ElementType->LLVMTy->getContext(), AddressSpace))); | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should remove these SandboxIR methods. They shouldn't have been copied into brand-new code...
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can look into this later. From what I can tell there's only a few uses, all of which are related to SandboxIR I'm not very familiar with SandboxIR, but from what I can tell it's relatively new. Do you think we also want a deprecation/removal process, or do you think it's fine to remove them?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's okay to remove them right away, no need to deprecate. |
||
|
|
||
| PointerType *PointerType::get(Context &Ctx, unsigned AddressSpace) { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -793,9 +793,9 @@ bool AArch64Arm64ECCallLowering::runOnModule(Module &Mod) { | |
| VoidTy = Type::getVoidTy(M->getContext()); | ||
|
|
||
| GuardFnType = FunctionType::get(PtrTy, {PtrTy, PtrTy}, false); | ||
| GuardFnPtrType = PointerType::get(GuardFnType, 0); | ||
| GuardFnPtrType = PointerType::get(M->getContext(), 0); | ||
| DispatchFnType = FunctionType::get(PtrTy, {PtrTy, PtrTy, PtrTy}, false); | ||
| DispatchFnPtrType = PointerType::get(DispatchFnType, 0); | ||
| DispatchFnPtrType = PointerType::get(M->getContext(), 0); | ||
|
||
| GuardFnCFGlobal = | ||
| M->getOrInsertGlobal("__os_arm64x_check_icall_cfg", GuardFnPtrType); | ||
| GuardFnGlobal = | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.