[WIP] Optimizing dynamic alloca ISEL #123746
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the allocation size for dynamic allocas,
first we scale the
max_sizeby thewave_size,and then bump SP by this amount.
Currently, during
DAG->DAG I-Sel, the scalarleft-shift and addition operations are being
folded into a
v_lshl_add_u32instructionand then
readfirstlaneis used to copy thevalue into SP.
This patch enforces the use of scalar operations,
removing the need for a
readfirstlaneinstr.This makes the code-gen for S-DAG and G-ISEL
uniform.