[libc][docs] disable pthreads docs #123824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a target named pthreads is breaking when multiple runtimes are enabled. Disable this target for now so that the builds go back to green (and sites get updated). Link: llvm/llvm-zorg#359 (comment) Link: llvm#122006 Link: llvm#122497 Link: llvm#123821
Member
|
@llvm/pr-subscribers-libc Author: Nick Desaulniers (nickdesaulniers) ChangesHaving a target named pthreads is breaking when multiple runtimes are enabled. Link: llvm/llvm-zorg#359 (comment) Full diff: https://github.com/llvm/llvm-project/pull/123824.diff 2 Files Affected:
diff --git a/libc/docs/CMakeLists.txt b/libc/docs/CMakeLists.txt
index f88d7c27f9f6b3..04eaa7f1b8a5dc 100644
--- a/libc/docs/CMakeLists.txt
+++ b/libc/docs/CMakeLists.txt
@@ -45,7 +45,8 @@ if (SPHINX_FOUND)
locale
net/if
netinet/in
- pthread
+ # TODO: https://github.com/llvm/llvm-project/issues/123821
+ # pthread
setjmp
signal
stdbit
diff --git a/libc/docs/headers/index.rst b/libc/docs/headers/index.rst
index 858b2142defa92..4a66d68ed902d8 100644
--- a/libc/docs/headers/index.rst
+++ b/libc/docs/headers/index.rst
@@ -17,7 +17,6 @@ Implementation Status
math/index.rst
net/if
netinet/in
- pthread
search
setjmp
signal
@@ -37,3 +36,6 @@ Implementation Status
uchar
wchar
wctype
+..
+ TODO: https://github.com/llvm/llvm-project/issues/123821
+ pthread
|
lntue
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a target named pthreads is breaking when multiple runtimes are enabled.
Disable this target for now so that the builds go back to green (and sites get
updated).
Link: llvm/llvm-zorg#359 (comment)
Link: #122006
Link: #122497
Link: #123821