Skip to content

[lldb] Avoid repeated map lookups (NFC) #123892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[lldb] Avoid repeated map lookups (NFC) #123892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions lldb/source/Target/Process.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,17 +1292,12 @@ bool Process::HasAssignedIndexIDToThread(uint64_t thread_id) {
}

uint32_t Process::AssignIndexIDToThread(uint64_t thread_id) {
uint32_t result = 0;
std::map<uint64_t, uint32_t>::iterator iterator =
m_thread_id_to_index_id_map.find(thread_id);
if (iterator == m_thread_id_to_index_id_map.end()) {
result = ++m_thread_index_id;
m_thread_id_to_index_id_map[thread_id] = result;
} else {
result = iterator->second;
}
auto [iterator, inserted] =
m_thread_id_to_index_id_map.try_emplace(thread_id, m_thread_index_id + 1);
if (inserted)
++m_thread_index_id;

return result;
return iterator->second;
}

StateType Process::GetState() {
Expand Down
Loading