Skip to content

[clang-format] Add null-terminated path option (#123921) #123926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[clang-format] Add null-terminated path option (#123921) #123926

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9dfbb9a
[clang-format] Add null-terminated path option (#123921)
createyourpersonalaccount Jan 22, 2025
6342476
do not print anything but list of files when null is enabled
createyourpersonalaccount Jan 24, 2025
6b9460a
improve help string
createyourpersonalaccount Jan 26, 2025
343fa15
improve print function to accept list of files
createyourpersonalaccount Jan 26, 2025
e2ecb4b
rename null option to print0
createyourpersonalaccount Jan 26, 2025
9bd8510
order command-line arguments alphabetically
createyourpersonalaccount Jan 26, 2025
ab12a7e
use new print function to print file lists
createyourpersonalaccount Jan 26, 2025
c47ce3c
remove default value from print_filenames argument
createyourpersonalaccount Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions clang/tools/clang-format/git-clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ def main():
"commits"
),
)
p.add_argument(
"-0",
"--null",
action="store_true",
help="print the affected paths with null-terminated characters",
)
# We gather all the remaining positional arguments into 'args' since we need
# to use some heuristics to determine whether or not <commit> was present.
# However, to print pretty messages, we make use of metavar and help.
Expand Down Expand Up @@ -261,11 +267,11 @@ def main():
"ignored by clang-format):"
)
for filename in ignored_files:
print(" %s" % filename)
print_filename(filename, opts.null)
if changed_lines:
print("Running clang-format on the following files:")
for filename in changed_lines:
print(" %s" % filename)
print_filename(filename, opts.null)

if not changed_lines:
if opts.verbose >= 0:
Expand Down Expand Up @@ -304,7 +310,7 @@ def main():
if (opts.verbose >= 0 and not opts.patch) or opts.verbose >= 1:
print("changed files:")
for filename in changed_files:
print(" %s" % filename)
print_filename(filename, opts.null)

return 1

Expand Down Expand Up @@ -869,5 +875,12 @@ def convert_string(bytes_input):
return str(bytes_input)


def print_filename(filename, null=False):
if null:
print(filename + "\0", end="")
else:
print(" %s" % filename)


if __name__ == "__main__":
sys.exit(main())
Loading