Skip to content

[libc] -Wimplicit-fallthrough, -Wwrite-strings and non-GCC warnings #124036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 7, 2025
Merged

[libc] -Wimplicit-fallthrough, -Wwrite-strings and non-GCC warnings #124036

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d600a01
-Wwrite-strings
vinay-deshmukh Jan 22, 2025
1c5c871
-Wimplicit-fallthrough
vinay-deshmukh Jan 22, 2025
51b9c57
non GCC warnings
vinay-deshmukh Jan 23, 2025
3cc6100
Merge remote-tracking branch 'upstream/main' into vinay-issue-119281-…
vinay-deshmukh Jan 23, 2025
be9ec1a
PR review comments
vinay-deshmukh Jan 25, 2025
ff3b741
Merge remote-tracking branch 'upstream/main' into vinay-issue-119281-…
vinay-deshmukh Jan 25, 2025
56c7755
Move `-Wextra-semi` and `-Wstrict-prototypes` back to Clang only
vinay-deshmukh Jan 29, 2025
519bf7b
Merge remote-tracking branch 'upstream/main' into vinay-issue-119281-…
vinay-deshmukh Jan 29, 2025
d8bf783
Update LLVMLibCTestRules.cmake
vinay-deshmukh Feb 5, 2025
9c91ac9
Fix NL
vinay-deshmukh Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions libc/cmake/modules/LLVMLibCTestRules.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
function(_get_common_test_compile_options output_var c_test flags)
_get_compile_options_from_flags(compile_flags ${flags})

# Remove -fno-math-errno if it was added.
if(LIBC_ADD_FNO_MATH_ERRNO)
list(REMOVE_ITEM compile_options "-fno-math-errno")
endif()
Copy link
Member

@nickdesaulniers nickdesaulniers Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to remove this?

Copy link
Contributor Author

@vinay-deshmukh vinay-deshmukh Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRFC yes, Oh I just realized that's removing -fno-math-error

let me revert that change


set(compile_options
${LIBC_COMPILE_OPTIONS_DEFAULT}
${LIBC_TEST_COMPILE_OPTIONS_DEFAULT}
Expand Down Expand Up @@ -38,9 +33,8 @@ function(_get_common_test_compile_options output_var c_test flags)
endif()
# list(APPEND compile_options "-Wconversion")
# list(APPEND compile_options "-Wno-sign-conversion")
# list(APPEND compile_options "-Wimplicit-fallthrough")
# list(APPEND compile_options "-Wwrite-strings")
list(APPEND compile_options "-Wextra-semi")
list(APPEND compile_options "-Wimplicit-fallthrough")
list(APPEND compile_options "-Wwrite-strings")
# Silence this warning because _Complex is a part of C99.
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
if(NOT c_test)
Expand All @@ -51,13 +45,14 @@ function(_get_common_test_compile_options output_var c_test flags)
list(APPEND compile_options "-Wno-gnu-imaginary-constant")
endif()
list(APPEND compile_options "-Wno-pedantic")
# if(NOT CMAKE_COMPILER_IS_GNUCXX)
# list(APPEND compile_options "-Wnewline-eof")
# list(APPEND compile_options "-Wnonportable-system-include-path")
# list(APPEND compile_options "-Wstrict-prototypes")
# list(APPEND compile_options "-Wthread-safety")
# list(APPEND compile_options "-Wglobal-constructors")
# endif()
if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
list(APPEND compile_options "-Wstrict-prototypes")
list(APPEND compile_options "-Wextra-semi")
list(APPEND compile_options "-Wnewline-eof")
list(APPEND compile_options "-Wnonportable-system-include-path")
list(APPEND compile_options "-Wthread-safety")
# list(APPEND compile_options "-Wglobal-constructors")
endif()
endif()
set(${output_var} ${compile_options} PARENT_SCOPE)
endfunction()
Expand Down