In openmp, recognize the NetBSD/powerpc ports. #124151
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
| #define KMP_ARCH_PPC_XCOFF 1 | ||
| #undef KMP_ARCH_PPC | ||
| #define KMP_ARCH_PPC 1 | ||
| #elif defined(__powerpc__) && defined(KMP_OS_NETBSD) |
There was a problem hiding this comment.
Instead of checking for KMP_OS_NETBSD since this really should not be NetBSD specific it would be better to check !__LP64__ since powerpc is defined even on powerpc64.
Also it would be good to have #define KMP_ARCH_PPC 0 further up around line 110.
3 participants
No description provided.