[llvm][Docs] Clarify the process for requesting a merge on your behalf #124154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more clear what you the author must do, and what reviewers can expect you to do, before an approved PR can be merged. Spliting out the email bit into a section also means we can link directly to it in discussions. This relies on one of those parties actually reading this, but I plan to tackle the case where they don't with new automation, coming later.
DavidSpickett
requested review from
AaronBallman,
ChuanqiXu9,
banach-space and
rengolin
preames
approved these changes
Jan 23, 2025
Collaborator
preames
left a comment
preames
left a comment
There was a problem hiding this comment.
LGTM w/optional suggestion.
rengolin
approved these changes
Jan 23, 2025
Member
rengolin
left a comment
rengolin
left a comment
There was a problem hiding this comment.
LGTM for what it's worth. I think the label will help.
ChuanqiXu9
approved these changes
Jan 24, 2025
Member
ChuanqiXu9
left a comment
ChuanqiXu9
left a comment
There was a problem hiding this comment.
BTW, I am not sure if it is possible to make a bot that suggests this when:
- The pr is approved. And,
- The author didn't have commit access
Collaborator
Author
I'm going to find out! - https://discourse.llvm.org/t/rfc-encouraging-reviewers-to-merge-on-behalf-of-pr-authors-without-commit-access/84180/14?u=davidspickett |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more clear what you the author must do, and what reviewers can expect you to do, before an approved PR can be merged. Spliting out the email bit into a section also means we can link directly to it in discussions.
This relies on one of those parties actually reading this, but I plan to tackle the case where they don't with some new automation.