Skip to content

[mlir][PDLL] Allow (and ignore) -D tablegen macros. #124166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[mlir][PDLL] Allow (and ignore) -D tablegen macros. #124166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mlir/tools/mlir-pdll/mlir-pdll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,15 @@ int main(int argc, char **argv) {
"write-if-changed",
llvm::cl::desc("Only write to the output file if it changed"));

// `ResetCommandLineParser` at the above unregistered the "D" option
// of `llvm-tblgen`, which causes tblgen usage to fail due to
// "Unknnown command line argument '-D...`" when a macros name is
// present. The following is a workaround to re-register it again.
llvm::cl::list<std::string> macroNames(
"D",
llvm::cl::desc("Name of the macro to be defined -- ignored by mlir-pdll"),
llvm::cl::value_desc("macro name"), llvm::cl::Prefix);

llvm::InitLLVM y(argc, argv);
llvm::cl::ParseCommandLineOptions(argc, argv, "PDLL Frontend");

Expand Down
Loading