Skip to content

[libc] Add returns_twice attribute to setjmp(3) #124370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2025
Merged

[libc] Add returns_twice attribute to setjmp(3) #124370

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5cc3187
[libc] Add `returns_twice` attribute to `setjmp(3)`
alanzhao1 Jan 24, 2025
3b19f8b
add attribute to setjmp_impl.h
alanzhao1 Jan 27, 2025
5047b8f
remove [[]] syntax
alanzhao1 Feb 5, 2025
6cb983a
use __attribute__ instead of [[]] in setjmp_impl.h for consistency
alanzhao1 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions libc/include/__llvm-libc-common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@
#define __NOEXCEPT throw()
#endif

#undef _Returns_twice
#define _Returns_twice [[gnu::returns_twice]]

#else // not __cplusplus

#undef __BEGIN_C_DECLS
Expand Down Expand Up @@ -80,6 +83,9 @@
#define __NOEXCEPT
#endif

#undef _Returns_twice
#define _Returns_twice __attribute__((returns_twice))

#endif // __cplusplus

#endif // LLVM_LIBC_COMMON_H
2 changes: 2 additions & 0 deletions libc/include/setjmp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,7 @@ functions:
standards:
- stdc
return_type: int
attributes:
- _Returns_twice
arguments:
- type: jmp_buf
3 changes: 2 additions & 1 deletion libc/src/setjmp/setjmp_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ namespace LIBC_NAMESPACE_DECL {
#ifdef LIBC_COMPILER_IS_GCC
[[gnu::nothrow]]
#endif
int setjmp(jmp_buf buf);
[[gnu::returns_twice]] int
setjmp(jmp_buf buf);

} // namespace LIBC_NAMESPACE_DECL

Expand Down
Loading