Skip to content

[SelectionDAG] WidenVecOp_INSERT_SUBVECTOR - Replace INSERT_SUBVECTOR with series of INSERT_VECTOR_ELT #124420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 28, 2025
Merged

[SelectionDAG] WidenVecOp_INSERT_SUBVECTOR - Replace INSERT_SUBVECTOR with series of INSERT_VECTOR_ELT #124420

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
085cc30
[SelectionDAG] Replace `INSERT_SUBVECTOR` with series of `INSERT_VECT…
abhishek-kaushik22 Jan 25, 2025
0a5a2e3
Use `getVectorIdxConstant`
abhishek-kaushik22 Jan 27, 2025
1cb71fa
Add tests
abhishek-kaushik22 Jan 27, 2025
275878c
Update LegalizeVectorTypes.cpp
abhishek-kaushik22 Jan 27, 2025
f3f6e57
Update LegalizeVectorTypes.cpp
abhishek-kaushik22 Jan 27, 2025
5324708
Address review comments
abhishek-kaushik22 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7040,8 +7040,11 @@ SDValue DAGTypeLegalizer::WidenVecOp_INSERT_SUBVECTOR(SDNode *N) {
SDValue SubVec = N->getOperand(1);
SDValue InVec = N->getOperand(0);

if (getTypeAction(SubVec.getValueType()) == TargetLowering::TypeWidenVector)
SubVec = GetWidenedVector(SubVec);
SDValue OrigSubVec;
if (getTypeAction(SubVec.getValueType()) == TargetLowering::TypeWidenVector) {
OrigSubVec = std::move(SubVec);
SubVec = GetWidenedVector(OrigSubVec);
}

EVT SubVT = SubVec.getValueType();

Expand Down Expand Up @@ -7070,8 +7073,23 @@ SDValue DAGTypeLegalizer::WidenVecOp_INSERT_SUBVECTOR(SDNode *N) {
return DAG.getNode(ISD::INSERT_SUBVECTOR, SDLoc(N), VT, InVec, SubVec,
N->getOperand(2));

report_fatal_error("Don't know how to widen the operands for "
"INSERT_SUBVECTOR");
// If the operands can't be widened legally, just replace the INSERT_SUBVECTOR
// with a series of INSERT_VECTOR_ELT
EVT OrigVT = OrigSubVec.getValueType();
unsigned Idx = N->getConstantOperandVal(2);

SDValue InsertVecElt;
SDLoc DL(N);
for (unsigned I = 0; I < OrigVT.getVectorNumElements(); ++I) {
SDValue Extract =
DAG.getNode(ISD::EXTRACT_VECTOR_ELT, DL, VT.getScalarType(), SubVec,
DAG.getIntPtrConstant(I, DL, /*isTarget*/ true));
InsertVecElt = DAG.getNode(ISD::INSERT_VECTOR_ELT, DL, VT,
I != 0 ? InsertVecElt : InVec, Extract,
DAG.getIntPtrConstant(I + Idx, DL, true));
}

return InsertVecElt;
}

SDValue DAGTypeLegalizer::WidenVecOp_EXTRACT_SUBVECTOR(SDNode *N) {
Expand Down
Loading