[ExecutionEngine][test][RISCV] Don't mark RISCV as unsupported #124464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to the MCJIT subdirectory means they can be gated by a common
lit.local.cfg. I remove the `; UNSUPPORTED: target=loongarch{{.*}}`
lines because of this.
The move is motivated by my desire to enable more of these tests for
RISCV, and it seems like it would be wrong to keep extending the
`UNSUPPORTED` lines for these individual tests.
This patch does not move the MCJIT tests in the top-level directory that
do `-force-interpreter=true`.
Although MCJIT is unsupported, we can and should be running the other tests. Stacks on top of llvm#124463 (needed to avoid unsupported MCJIT tests in the top-level test/ExecutionEngine directory running when they shouldn't). This effectively reverts b8feeba. ninja check-llvm-executionengine before: Total Discovered Tests: 335 Unsupported: 335 (100.00%) ninja check-llvm-executionengine after: Total Discovered Tests: 335 Unsupported : 125 (37.31%) Passed : 209 (62.39%) Expectedly Failed: 1 (0.30%)
21 tasks
preames
approved these changes
Jan 27, 2025
Collaborator
preames
left a comment
preames
left a comment
There was a problem hiding this comment.
LGTM
As a follow up, would you mind moving the force-interpreter tests into the Interpreter subtree?
lhames
approved these changes
Jan 28, 2025
asb
added a commit
to asb/llvm-project
that referenced
this pull request
Jan 28, 2025
…subdirectory I left these alone in llvm#124463 but I think it makes sense to clean these up as well (which Philip also noted in llvm#124464).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although MCJIT is unsupported, we can and should be running the other
tests. Stacks on top of #124463 (needed to avoid unsupported MCJIT tests
in the top-level test/ExecutionEngine directory running when they
shouldn't).
This effectively reverts b8feeba.
ninja check-llvm-executionengine before:
Total Discovered Tests: 335
Unsupported: 335 (100.00%)
ninja check-llvm-executionengine after:
Total Discovered Tests: 335
Unsupported : 125 (37.31%)
Passed : 209 (62.39%)
Expectedly Failed: 1 (0.30%)