Skip to content

[AMDGPU][GlobalISel] Fix assert on APInt creation. #124608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfukalov merged 3 commits into from
Jan 28, 2025
Merged

[AMDGPU][GlobalISel] Fix assert on APInt creation. #124608

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6595176
[AMDGPU][GlobalISel] Fix assert on APInt creation.
dfukalov Jan 27, 2025
3023d8a
fixup! [AMDGPU][GlobalISel] Fix assert on APInt creation.
dfukalov Jan 27, 2025
2ea9ccd
fixup! fixup! [AMDGPU][GlobalISel] Fix assert on APInt creation.
dfukalov Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Target/AMDGPU/AMDGPUGlobalISelUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ AMDGPU::getBaseWithConstantOffset(MachineRegisterInfo &MRI, Register Reg,

Register Base;
if (KnownBits && mi_match(Reg, MRI, m_GOr(m_Reg(Base), m_ICst(Offset))) &&
KnownBits->maskedValueIsZero(Base, APInt(32, Offset)))
KnownBits->maskedValueIsZero(Base, APInt(32, Offset, /*isSigned=*/true)))
Copy link
Contributor

@arsenm arsenm Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APSint?

Copy link
Collaborator Author

@dfukalov dfukalov Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jay suggested to use APInt in the same case #122251 (comment)

@jayfoad?

Copy link
Contributor

@jayfoad jayfoad Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the suggestion? I don't even see how you could use APSInt here.

Copy link
Collaborator Author

@dfukalov dfukalov Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, indeed, that was just an incorrect usage of APSInt(BitWidth, isUnsigned)...

return std::pair(Base, Offset);

// Handle G_PTRTOINT (G_PTR_ADD base, const) case
Expand Down
14 changes: 14 additions & 0 deletions llvm/test/CodeGen/AMDGPU/GlobalISel/assert-signed-apint.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
; REQUIRES: asserts
Copy link
Contributor

@arsenm arsenm Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not require asserts

; RUN: llc -global-isel -mtriple=amdgcn -mcpu=gfx1200 -verify-machineinstrs -stop-after=instruction-select -o - %s | FileCheck %s
Copy link
Contributor

@arsenm arsenm Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need -verify-machineinstrs


; Check that APInt doesn't assert on creation from -2147483648 value.

; CHECK-LABEL: @test
; CHECK: S_BUFFER_LOAD_DWORD_SGPR_IMM
Copy link
Contributor

@arsenm arsenm Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use update_mir_test_checks


define amdgpu_cs void @test(<4 x i32> inreg %base, i32 inreg %i, ptr addrspace(1) inreg %out) {
Copy link
Contributor

@jayfoad jayfoad Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add this case to an existing file that tests buffer offsets?

%off = or i32 %i, -2147483648
%v = call i32 @llvm.amdgcn.s.buffer.load.i32(<4 x i32> %base, i32 %off, i32 0)
store i32 %v, ptr addrspace(1) %out, align 4
ret void
}
Loading