[DependenceAnalysis][NFC] Removing PossiblyLoopIndependent parameter #124615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
llvm:analysis
Member
|
@llvm/pr-subscribers-llvm-analysis Author: Alireza Torabian (1997alireza) ChangesParameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely. This is an NFC patch. Full diff: https://github.com/llvm/llvm-project/pull/124615.diff 9 Files Affected:
diff --git a/llvm/include/llvm/Analysis/DDG.h b/llvm/include/llvm/Analysis/DDG.h
index be5f746e31a573..dfd84a9addb970 100644
--- a/llvm/include/llvm/Analysis/DDG.h
+++ b/llvm/include/llvm/Analysis/DDG.h
@@ -453,7 +453,7 @@ bool DependenceGraphInfo<NodeType>::getDependencies(
for (auto *SrcI : SrcIList)
for (auto *DstI : DstIList)
if (auto Dep =
- const_cast<DependenceInfo *>(&DI)->depends(SrcI, DstI, true))
+ const_cast<DependenceInfo *>(&DI)->depends(SrcI, DstI))
Deps.push_back(std::move(Dep));
return !Deps.empty();
diff --git a/llvm/include/llvm/Analysis/DependenceAnalysis.h b/llvm/include/llvm/Analysis/DependenceAnalysis.h
index f0a09644e0f4b6..426ac757b4b0da 100644
--- a/llvm/include/llvm/Analysis/DependenceAnalysis.h
+++ b/llvm/include/llvm/Analysis/DependenceAnalysis.h
@@ -303,12 +303,8 @@ namespace llvm {
/// depends - Tests for a dependence between the Src and Dst instructions.
/// Returns NULL if no dependence; otherwise, returns a Dependence (or a
/// FullDependence) with as much information as can be gleaned.
- /// The flag PossiblyLoopIndependent should be set by the caller
- /// if it appears that control flow can reach from Src to Dst
- /// without traversing a loop back edge.
std::unique_ptr<Dependence> depends(Instruction *Src,
- Instruction *Dst,
- bool PossiblyLoopIndependent);
+ Instruction *Dst);
/// getSplitIteration - Give a dependence that's splittable at some
/// particular level, return the iteration that should be used to split
diff --git a/llvm/lib/Analysis/DependenceAnalysis.cpp b/llvm/lib/Analysis/DependenceAnalysis.cpp
index a4a98ea0bae146..9858381a8b7d01 100644
--- a/llvm/lib/Analysis/DependenceAnalysis.cpp
+++ b/llvm/lib/Analysis/DependenceAnalysis.cpp
@@ -187,7 +187,7 @@ static void dumpExampleDependence(raw_ostream &OS, DependenceInfo *DA,
if (DstI->mayReadOrWriteMemory()) {
OS << "Src:" << *SrcI << " --> Dst:" << *DstI << "\n";
OS << " da analyze - ";
- if (auto D = DA->depends(&*SrcI, &*DstI, true)) {
+ if (auto D = DA->depends(&*SrcI, &*DstI)) {
// Normalize negative direction vectors if required by clients.
if (NormalizeResults && D->normalize(&SE))
OS << "normalized - ";
@@ -3586,8 +3586,8 @@ bool DependenceInfo::invalidate(Function &F, const PreservedAnalyses &PA,
// Care is required to keep the routine below, getSplitIteration(),
// up to date with respect to this routine.
std::unique_ptr<Dependence>
-DependenceInfo::depends(Instruction *Src, Instruction *Dst,
- bool PossiblyLoopIndependent) {
+DependenceInfo::depends(Instruction *Src, Instruction *Dst) {
+ bool PossiblyLoopIndependent = true;
if (Src == Dst)
PossiblyLoopIndependent = false;
diff --git a/llvm/lib/Analysis/DependenceGraphBuilder.cpp b/llvm/lib/Analysis/DependenceGraphBuilder.cpp
index 7ee2adf49ebb41..80a17613ddad2a 100644
--- a/llvm/lib/Analysis/DependenceGraphBuilder.cpp
+++ b/llvm/lib/Analysis/DependenceGraphBuilder.cpp
@@ -297,7 +297,7 @@ void AbstractDependenceGraphBuilder<G>::createMemoryDependencyEdges() {
bool BackwardEdgeCreated = false;
for (Instruction *ISrc : SrcIList) {
for (Instruction *IDst : DstIList) {
- auto D = DI.depends(ISrc, IDst, true);
+ auto D = DI.depends(ISrc, IDst);
if (!D)
continue;
diff --git a/llvm/lib/Analysis/LoopCacheAnalysis.cpp b/llvm/lib/Analysis/LoopCacheAnalysis.cpp
index 2897b922f61e48..050c32707596a7 100644
--- a/llvm/lib/Analysis/LoopCacheAnalysis.cpp
+++ b/llvm/lib/Analysis/LoopCacheAnalysis.cpp
@@ -224,7 +224,7 @@ IndexedReference::hasTemporalReuse(const IndexedReference &Other,
}
std::unique_ptr<Dependence> D =
- DI.depends(&StoreOrLoadInst, &Other.StoreOrLoadInst, true);
+ DI.depends(&StoreOrLoadInst, &Other.StoreOrLoadInst);
if (D == nullptr) {
LLVM_DEBUG(dbgs().indent(2) << "No temporal reuse: no dependence\n");
diff --git a/llvm/lib/Transforms/Scalar/LoopFuse.cpp b/llvm/lib/Transforms/Scalar/LoopFuse.cpp
index 46b0783004fcdb..eaf89b23c26f76 100644
--- a/llvm/lib/Transforms/Scalar/LoopFuse.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopFuse.cpp
@@ -1099,7 +1099,7 @@ struct LoopFuser {
LLVM_DEBUG(dbgs() << "Checking if this mem inst can be hoisted.\n");
for (Instruction *NotHoistedInst : NotHoisting) {
- if (auto D = DI.depends(&I, NotHoistedInst, true)) {
+ if (auto D = DI.depends(&I, NotHoistedInst)) {
// Dependency is not read-before-write, write-before-read or
// write-before-write
if (D->isFlow() || D->isAnti() || D->isOutput()) {
@@ -1111,7 +1111,7 @@ struct LoopFuser {
}
for (Instruction *ReadInst : FC0.MemReads) {
- if (auto D = DI.depends(ReadInst, &I, true)) {
+ if (auto D = DI.depends(ReadInst, &I)) {
// Dependency is not read-before-write
if (D->isAnti()) {
LLVM_DEBUG(dbgs() << "Inst depends on a read instruction in FC0.\n");
@@ -1121,7 +1121,7 @@ struct LoopFuser {
}
for (Instruction *WriteInst : FC0.MemWrites) {
- if (auto D = DI.depends(WriteInst, &I, true)) {
+ if (auto D = DI.depends(WriteInst, &I)) {
// Dependency is not write-before-read or write-before-write
if (D->isFlow() || D->isOutput()) {
LLVM_DEBUG(dbgs() << "Inst depends on a write instruction in FC0.\n");
@@ -1153,7 +1153,7 @@ struct LoopFuser {
return true;
for (Instruction *ReadInst : FC1.MemReads) {
- if (auto D = DI.depends(&I, ReadInst, true)) {
+ if (auto D = DI.depends(&I, ReadInst)) {
// Dependency is not write-before-read
if (D->isFlow()) {
LLVM_DEBUG(dbgs() << "Inst depends on a read instruction in FC1.\n");
@@ -1163,7 +1163,7 @@ struct LoopFuser {
}
for (Instruction *WriteInst : FC1.MemWrites) {
- if (auto D = DI.depends(&I, WriteInst, true)) {
+ if (auto D = DI.depends(&I, WriteInst)) {
// Dependency is not write-before-write or read-before-write
if (D->isOutput() || D->isAnti()) {
LLVM_DEBUG(dbgs() << "Inst depends on a write instruction in FC1.\n");
@@ -1335,7 +1335,7 @@ struct LoopFuser {
case FUSION_DEPENDENCE_ANALYSIS_SCEV:
return accessDiffIsPositive(*FC0.L, *FC1.L, I0, I1, AnyDep);
case FUSION_DEPENDENCE_ANALYSIS_DA: {
- auto DepResult = DI.depends(&I0, &I1, true);
+ auto DepResult = DI.depends(&I0, &I1);
if (!DepResult)
return true;
#ifndef NDEBUG
diff --git a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
index 38fc682698c53e..aac75b8962eb99 100644
--- a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
@@ -146,7 +146,7 @@ static bool populateDependencyMatrix(CharMatrix &DepMatrix, unsigned Level,
if (isa<LoadInst>(Src) && isa<LoadInst>(Dst))
continue;
// Track Output, Flow, and Anti dependencies.
- if (auto D = DI->depends(Src, Dst, true)) {
+ if (auto D = DI->depends(Src, Dst)) {
assert(D->isOrdered() && "Expected an output, flow or anti dep.");
// If the direction vector is negative, normalize it to
// make it non-negative.
diff --git a/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp b/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
index f34e9c5818dd67..7bbb451782dda1 100644
--- a/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
+++ b/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
@@ -398,7 +398,7 @@ bool llvm::isSafeToMoveBefore(Instruction &I, Instruction &InsertPoint,
// Check if I has any output/flow/anti dependences with instructions from \p
// StartInst to \p EndInst.
if (llvm::any_of(InstsToCheck, [&DI, &I](Instruction *CurInst) {
- auto DepResult = DI->depends(&I, CurInst, true);
+ auto DepResult = DI->depends(&I, CurInst);
if (DepResult && (DepResult->isOutput() || DepResult->isFlow() ||
DepResult->isAnti()))
return true;
diff --git a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
index 49209e33f2d1dd..d9ca38eed75888 100644
--- a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
@@ -708,7 +708,7 @@ static bool checkDependency(Instruction *Src, Instruction *Dst,
// (0,0,>=,*,*)
// Now, the dependency is not necessarily non-negative anymore, i.e.
// unroll-and-jam may violate correctness.
- std::unique_ptr<Dependence> D = DI.depends(Src, Dst, true);
+ std::unique_ptr<Dependence> D = DI.depends(Src, Dst);
if (!D)
return true;
assert(D->isOrdered() && "Expected an output, flow or anti dep.");
|
Member
|
@llvm/pr-subscribers-llvm-transforms Author: Alireza Torabian (1997alireza) ChangesParameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely. This is an NFC patch. Full diff: https://github.com/llvm/llvm-project/pull/124615.diff 9 Files Affected:
diff --git a/llvm/include/llvm/Analysis/DDG.h b/llvm/include/llvm/Analysis/DDG.h
index be5f746e31a573..dfd84a9addb970 100644
--- a/llvm/include/llvm/Analysis/DDG.h
+++ b/llvm/include/llvm/Analysis/DDG.h
@@ -453,7 +453,7 @@ bool DependenceGraphInfo<NodeType>::getDependencies(
for (auto *SrcI : SrcIList)
for (auto *DstI : DstIList)
if (auto Dep =
- const_cast<DependenceInfo *>(&DI)->depends(SrcI, DstI, true))
+ const_cast<DependenceInfo *>(&DI)->depends(SrcI, DstI))
Deps.push_back(std::move(Dep));
return !Deps.empty();
diff --git a/llvm/include/llvm/Analysis/DependenceAnalysis.h b/llvm/include/llvm/Analysis/DependenceAnalysis.h
index f0a09644e0f4b6..426ac757b4b0da 100644
--- a/llvm/include/llvm/Analysis/DependenceAnalysis.h
+++ b/llvm/include/llvm/Analysis/DependenceAnalysis.h
@@ -303,12 +303,8 @@ namespace llvm {
/// depends - Tests for a dependence between the Src and Dst instructions.
/// Returns NULL if no dependence; otherwise, returns a Dependence (or a
/// FullDependence) with as much information as can be gleaned.
- /// The flag PossiblyLoopIndependent should be set by the caller
- /// if it appears that control flow can reach from Src to Dst
- /// without traversing a loop back edge.
std::unique_ptr<Dependence> depends(Instruction *Src,
- Instruction *Dst,
- bool PossiblyLoopIndependent);
+ Instruction *Dst);
/// getSplitIteration - Give a dependence that's splittable at some
/// particular level, return the iteration that should be used to split
diff --git a/llvm/lib/Analysis/DependenceAnalysis.cpp b/llvm/lib/Analysis/DependenceAnalysis.cpp
index a4a98ea0bae146..9858381a8b7d01 100644
--- a/llvm/lib/Analysis/DependenceAnalysis.cpp
+++ b/llvm/lib/Analysis/DependenceAnalysis.cpp
@@ -187,7 +187,7 @@ static void dumpExampleDependence(raw_ostream &OS, DependenceInfo *DA,
if (DstI->mayReadOrWriteMemory()) {
OS << "Src:" << *SrcI << " --> Dst:" << *DstI << "\n";
OS << " da analyze - ";
- if (auto D = DA->depends(&*SrcI, &*DstI, true)) {
+ if (auto D = DA->depends(&*SrcI, &*DstI)) {
// Normalize negative direction vectors if required by clients.
if (NormalizeResults && D->normalize(&SE))
OS << "normalized - ";
@@ -3586,8 +3586,8 @@ bool DependenceInfo::invalidate(Function &F, const PreservedAnalyses &PA,
// Care is required to keep the routine below, getSplitIteration(),
// up to date with respect to this routine.
std::unique_ptr<Dependence>
-DependenceInfo::depends(Instruction *Src, Instruction *Dst,
- bool PossiblyLoopIndependent) {
+DependenceInfo::depends(Instruction *Src, Instruction *Dst) {
+ bool PossiblyLoopIndependent = true;
if (Src == Dst)
PossiblyLoopIndependent = false;
diff --git a/llvm/lib/Analysis/DependenceGraphBuilder.cpp b/llvm/lib/Analysis/DependenceGraphBuilder.cpp
index 7ee2adf49ebb41..80a17613ddad2a 100644
--- a/llvm/lib/Analysis/DependenceGraphBuilder.cpp
+++ b/llvm/lib/Analysis/DependenceGraphBuilder.cpp
@@ -297,7 +297,7 @@ void AbstractDependenceGraphBuilder<G>::createMemoryDependencyEdges() {
bool BackwardEdgeCreated = false;
for (Instruction *ISrc : SrcIList) {
for (Instruction *IDst : DstIList) {
- auto D = DI.depends(ISrc, IDst, true);
+ auto D = DI.depends(ISrc, IDst);
if (!D)
continue;
diff --git a/llvm/lib/Analysis/LoopCacheAnalysis.cpp b/llvm/lib/Analysis/LoopCacheAnalysis.cpp
index 2897b922f61e48..050c32707596a7 100644
--- a/llvm/lib/Analysis/LoopCacheAnalysis.cpp
+++ b/llvm/lib/Analysis/LoopCacheAnalysis.cpp
@@ -224,7 +224,7 @@ IndexedReference::hasTemporalReuse(const IndexedReference &Other,
}
std::unique_ptr<Dependence> D =
- DI.depends(&StoreOrLoadInst, &Other.StoreOrLoadInst, true);
+ DI.depends(&StoreOrLoadInst, &Other.StoreOrLoadInst);
if (D == nullptr) {
LLVM_DEBUG(dbgs().indent(2) << "No temporal reuse: no dependence\n");
diff --git a/llvm/lib/Transforms/Scalar/LoopFuse.cpp b/llvm/lib/Transforms/Scalar/LoopFuse.cpp
index 46b0783004fcdb..eaf89b23c26f76 100644
--- a/llvm/lib/Transforms/Scalar/LoopFuse.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopFuse.cpp
@@ -1099,7 +1099,7 @@ struct LoopFuser {
LLVM_DEBUG(dbgs() << "Checking if this mem inst can be hoisted.\n");
for (Instruction *NotHoistedInst : NotHoisting) {
- if (auto D = DI.depends(&I, NotHoistedInst, true)) {
+ if (auto D = DI.depends(&I, NotHoistedInst)) {
// Dependency is not read-before-write, write-before-read or
// write-before-write
if (D->isFlow() || D->isAnti() || D->isOutput()) {
@@ -1111,7 +1111,7 @@ struct LoopFuser {
}
for (Instruction *ReadInst : FC0.MemReads) {
- if (auto D = DI.depends(ReadInst, &I, true)) {
+ if (auto D = DI.depends(ReadInst, &I)) {
// Dependency is not read-before-write
if (D->isAnti()) {
LLVM_DEBUG(dbgs() << "Inst depends on a read instruction in FC0.\n");
@@ -1121,7 +1121,7 @@ struct LoopFuser {
}
for (Instruction *WriteInst : FC0.MemWrites) {
- if (auto D = DI.depends(WriteInst, &I, true)) {
+ if (auto D = DI.depends(WriteInst, &I)) {
// Dependency is not write-before-read or write-before-write
if (D->isFlow() || D->isOutput()) {
LLVM_DEBUG(dbgs() << "Inst depends on a write instruction in FC0.\n");
@@ -1153,7 +1153,7 @@ struct LoopFuser {
return true;
for (Instruction *ReadInst : FC1.MemReads) {
- if (auto D = DI.depends(&I, ReadInst, true)) {
+ if (auto D = DI.depends(&I, ReadInst)) {
// Dependency is not write-before-read
if (D->isFlow()) {
LLVM_DEBUG(dbgs() << "Inst depends on a read instruction in FC1.\n");
@@ -1163,7 +1163,7 @@ struct LoopFuser {
}
for (Instruction *WriteInst : FC1.MemWrites) {
- if (auto D = DI.depends(&I, WriteInst, true)) {
+ if (auto D = DI.depends(&I, WriteInst)) {
// Dependency is not write-before-write or read-before-write
if (D->isOutput() || D->isAnti()) {
LLVM_DEBUG(dbgs() << "Inst depends on a write instruction in FC1.\n");
@@ -1335,7 +1335,7 @@ struct LoopFuser {
case FUSION_DEPENDENCE_ANALYSIS_SCEV:
return accessDiffIsPositive(*FC0.L, *FC1.L, I0, I1, AnyDep);
case FUSION_DEPENDENCE_ANALYSIS_DA: {
- auto DepResult = DI.depends(&I0, &I1, true);
+ auto DepResult = DI.depends(&I0, &I1);
if (!DepResult)
return true;
#ifndef NDEBUG
diff --git a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
index 38fc682698c53e..aac75b8962eb99 100644
--- a/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopInterchange.cpp
@@ -146,7 +146,7 @@ static bool populateDependencyMatrix(CharMatrix &DepMatrix, unsigned Level,
if (isa<LoadInst>(Src) && isa<LoadInst>(Dst))
continue;
// Track Output, Flow, and Anti dependencies.
- if (auto D = DI->depends(Src, Dst, true)) {
+ if (auto D = DI->depends(Src, Dst)) {
assert(D->isOrdered() && "Expected an output, flow or anti dep.");
// If the direction vector is negative, normalize it to
// make it non-negative.
diff --git a/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp b/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
index f34e9c5818dd67..7bbb451782dda1 100644
--- a/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
+++ b/llvm/lib/Transforms/Utils/CodeMoverUtils.cpp
@@ -398,7 +398,7 @@ bool llvm::isSafeToMoveBefore(Instruction &I, Instruction &InsertPoint,
// Check if I has any output/flow/anti dependences with instructions from \p
// StartInst to \p EndInst.
if (llvm::any_of(InstsToCheck, [&DI, &I](Instruction *CurInst) {
- auto DepResult = DI->depends(&I, CurInst, true);
+ auto DepResult = DI->depends(&I, CurInst);
if (DepResult && (DepResult->isOutput() || DepResult->isFlow() ||
DepResult->isAnti()))
return true;
diff --git a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
index 49209e33f2d1dd..d9ca38eed75888 100644
--- a/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp
@@ -708,7 +708,7 @@ static bool checkDependency(Instruction *Src, Instruction *Dst,
// (0,0,>=,*,*)
// Now, the dependency is not necessarily non-negative anymore, i.e.
// unroll-and-jam may violate correctness.
- std::unique_ptr<Dependence> D = DI.depends(Src, Dst, true);
+ std::unique_ptr<Dependence> D = DI.depends(Src, Dst);
if (!D)
return true;
assert(D->isOrdered() && "Expected an output, flow or anti dep.");
|
Narutoworld
requested review from
CongzheUalberta,
nikic,
sebpop and
sjoerdmeijer
CongzheUalberta
requested changes
Feb 5, 2025
CongzheUalberta
approved these changes
Feb 6, 2025
1997alireza
force-pushed
the
da-remove-parameter
branch
from
28dae03 to
7a0e84b
Compare
…rameters Parameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely.
1997alireza
force-pushed
the
da-remove-parameter
branch
from
7a0e84b to
01c3378
Compare
|
@1997alireza Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…lvm#124615) Parameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely. This is an NFC patch.
Member
|
Nvmd, did a clean and build and the issue finally went away.
FAILED: bin/clang-import-test
: && /mnt/DevDrive/bin/clang++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -fno-common -Woverloaded-virtual -Wno-nested-anon-types -g -fuse-ld=lld -Wl,--color-diagnostics tools/clang/tools/clang-import-test/CMakeFiles/clang-import-test.dir/clang-import-test.cpp.o -o bin/clang-import-test -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMCore.a lib/libLLVMSupport.a lib/libLLVMTargetParser.a lib/libclangAST.a lib/libclangBasic.a lib/libclangCodeGen.a lib/libclangDriver.a lib/libclangFrontend.a lib/libclangLex.a lib/libclangParse.a lib/libclangSerialization.a lib/libclangDriver.a lib/libLLVMWindowsDriver.a lib/libLLVMOption.a lib/libclangSema.a lib/libclangAPINotes.a lib/libclangEdit.a lib/libclangSupport.a lib/libclangAnalysis.a lib/libclangASTMatchers.a lib/libclangAST.a lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCoverage.a lib/libLLVMFrontendDriver.a lib/libLLVMFrontendHLSL.a lib/libLLVMLTO.a lib/libLLVMExtensions.a lib/libLLVMPasses.a lib/libLLVMCoroutines.a lib/libLLVMHipStdPar.a lib/libLLVMipo.a lib/libLLVMFrontendOpenMP.a lib/libLLVMFrontendOffloading.a lib/libLLVMObjectYAML.a lib/libLLVMFrontendAtomic.a lib/libLLVMLinker.a lib/libLLVMIRPrinter.a lib/libLLVMInstrumentation.a lib/libLLVMVectorize.a lib/libLLVMSandboxIR.a lib/libLLVMCodeGen.a lib/libLLVMCodeGenTypes.a lib/libLLVMObjCARCOpts.a lib/libLLVMCGData.a lib/libLLVMBitWriter.a lib/libLLVMCFGuard.a lib/libLLVMScalarOpts.a lib/libLLVMAggressiveInstCombine.a lib/libLLVMInstCombine.a lib/libLLVMTarget.a lib/libLLVMTransformUtils.a lib/libLLVMAnalysis.a lib/libLLVMProfileData.a lib/libLLVMSymbolize.a lib/libLLVMDebugInfoPDB.a lib/libLLVMDebugInfoCodeView.a lib/libLLVMDebugInfoMSF.a lib/libLLVMDebugInfoBTF.a lib/libLLVMDebugInfoDWARF.a lib/libLLVMObject.a lib/libLLVMIRReader.a lib/libLLVMBitReader.a lib/libLLVMAsmParser.a lib/libLLVMCore.a lib/libLLVMRemarks.a lib/libLLVMBitstreamReader.a lib/libLLVMMCParser.a lib/libLLVMMC.a lib/libLLVMTextAPI.a lib/libLLVMBinaryFormat.a lib/libLLVMTargetParser.a lib/libLLVMSupport.a lib/libLLVMDemangle.a -lrt -ldl -lm /usr/lib/x86_64-linux-gnu/libz.so && :
ld.lld: error: undefined symbol: llvm::DependenceInfo::depends(llvm::Instruction*, llvm::Instruction*, bool)
>>> referenced by DDG.h:456 (/mnt/DevDrive/projects/llvm-project/llvm/include/llvm/Analysis/DDG.h:456)
>>> DDGPrinter.cpp.o:(llvm::DependenceGraphInfo<llvm::DDGNode>::getDependencies(llvm::DDGNode const&, llvm::DDGNode const&, llvm::SmallVector<std::unique_ptr<llvm::Dependence, std::default_delete<llvm::Dependence>>, 1u>&) const) in archive lib/libLLVMAnalysis.a
>>> did you mean: llvm::DependenceInfo::depends(llvm::Instruction*, llvm::Instruction*)
>>> defined in: lib/libLLVMAnalysis.a(DependenceAnalysis.cpp.o)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
|
flovent
pushed a commit
to flovent/llvm-project
that referenced
this pull request
Feb 13, 2025
…lvm#124615) Parameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely. This is an NFC patch.
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
…lvm#124615) Parameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely. This is an NFC patch.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
…lvm#124615) Parameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely. This is an NFC patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter PossiblyLoopIndependent has lost its intended purpose. This flag is always set to true in all cases when depends() is called, hence we want to reconsider the utility of this variable and remove it from the function signature entirely. This is an NFC patch.