Skip to content

[LLVM] Automatically strip -fno-lifetime-dse from compile_commands.json #124623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[LLVM] Automatically strip -fno-lifetime-dse from compile_commands.json #124623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eac4554
[LLVM] Automatically strip `-fno-lifetime-dse` from compile_commands.…
jhuber6 Jan 27, 2025
54bdfd1
comments
jhuber6 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions llvm/utils/merge-json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import argparse
import json
import sys
import os


def main():
Expand All @@ -35,6 +36,14 @@ def main():
except (IOError, json.JSONDecodeError) as e:
continue

# LLVM passes this argument by default but it is not supported by clang,
# causing annoying errors in the generated compile_commands.json file.
# Remove it here before we deduplicate the entries.
for entry in merged_data:
if isinstance(entry, dict) and "command" in entry:
if os.path.basename(entry["command"].partition(" ")[0]) != "g++":
entry["command"] = entry["command"].replace("-fno-lifetime-dse ", "")

# Deduplicate by converting each entry to a tuple of sorted key-value pairs
unique_data = list({json.dumps(entry, sort_keys=True) for entry in merged_data})
unique_data = [json.loads(entry) for entry in unique_data]
Expand Down