Skip to content

[X86] Use new Flags argument to storeRegToStackSlot to simplify code. NFC #124658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topperc merged 1 commit into from
Jan 29, 2025
Merged

[X86] Use new Flags argument to storeRegToStackSlot to simplify code. NFC #124658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions llvm/lib/Target/X86/X86FrameLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3062,10 +3062,7 @@ bool X86FrameLowering::spillCalleeSavedRegisters(
const TargetRegisterClass *RC = TRI->getMinimalPhysRegClass(Reg, VT);

TII.storeRegToStackSlot(MBB, MI, Reg, true, I.getFrameIdx(), RC, TRI,
Register());
--MI;
MI->setFlag(MachineInstr::FrameSetup);
++MI;
Register(), MachineInstr::FrameSetup);
}

return true;
Expand Down
7 changes: 4 additions & 3 deletions llvm/lib/Target/X86/X86InstrInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4801,7 +4801,8 @@ void X86InstrInfo::storeRegToStackSlot(
loadStoreTileReg(MBB, MI, Opc, SrcReg, FrameIdx, isKill);
else
addFrameReference(BuildMI(MBB, MI, DebugLoc(), get(Opc)), FrameIdx)
.addReg(SrcReg, getKillRegState(isKill));
.addReg(SrcReg, getKillRegState(isKill))
.setMIFlag(Flags);
}

void X86InstrInfo::loadRegFromStackSlot(
Expand All @@ -4821,8 +4822,8 @@ void X86InstrInfo::loadRegFromStackSlot(
if (isAMXOpcode(Opc))
loadStoreTileReg(MBB, MI, Opc, DestReg, FrameIdx);
else
addFrameReference(BuildMI(MBB, MI, DebugLoc(), get(Opc), DestReg),
FrameIdx);
addFrameReference(BuildMI(MBB, MI, DebugLoc(), get(Opc), DestReg), FrameIdx)
.setMIFlag(Flags);
Copy link
Contributor

@phoebewang phoebewang Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we don't set FrameDestroy in restoreCalleeSavedRegisters. Is it a bug or intended?

Copy link
Collaborator Author

@topperc topperc Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure.

}

bool X86InstrInfo::analyzeCompare(const MachineInstr &MI, Register &SrcReg,
Expand Down
Loading