Skip to content

[flang] Fix crash on SMP with dummy procedure #124663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[flang] Fix crash on SMP with dummy procedure #124663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion flang/lib/Semantics/resolve-names-utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,11 @@ void SymbolMapper::MapSymbolExprs(Symbol &symbol) {
proc.set_procInterfaces(
*mappedSymbol, BypassGeneric(mappedSymbol->GetUltimate()));
} else if (const DeclTypeSpec * mappedType{MapType(proc.type())}) {
proc.set_type(*mappedType);
if (proc.type()) {
CHECK(*proc.type() == *mappedType);
} else {
proc.set_type(*mappedType);
}
}
if (proc.init()) {
if (const Symbol * mapped{MapSymbol(*proc.init())}) {
Expand Down
14 changes: 14 additions & 0 deletions flang/test/Semantics/bug124487.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
!RUN: %flang_fc1 -fsyntax-only %s 2>&1 | FileCheck --allow-empty %s
!CHECK-NOT: error:
module m
interface
module subroutine smp(x)
character, external :: x
end
end interface
end
submodule (m) sm
contains
module procedure smp ! crashes here
end
end