Skip to content

[CodeGen] Avoid repeated hash lookups (NFC) #124677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 1 commit into from
Jan 28, 2025
+10 −11
Merged

[CodeGen] Avoid repeated hash lookups (NFC) #124677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions llvm/lib/CodeGen/SelectOptimize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,9 +483,9 @@ static Value *getTrueOrFalseValue(
BasicBlock *B) {
Value *V = isTrue ? SI.getTrueValue() : SI.getFalseValue();
if (V) {
auto *IV = dyn_cast<Instruction>(V);
if (IV && OptSelects.count(IV))
return isTrue ? OptSelects[IV].first : OptSelects[IV].second;
if (auto *IV = dyn_cast<Instruction>(V))
if (auto It = OptSelects.find(IV); It != OptSelects.end())
return isTrue ? It->second.first : It->second.second;
return V;
}

Expand All @@ -508,9 +508,8 @@ static Value *getTrueOrFalseValue(

unsigned OtherIdx = 1 - CondIdx;
if (auto *IV = dyn_cast<Instruction>(CBO->getOperand(OtherIdx))) {
if (OptSelects.count(IV))
CBO->setOperand(OtherIdx,
isTrue ? OptSelects[IV].first : OptSelects[IV].second);
if (auto It = OptSelects.find(IV); It != OptSelects.end())
CBO->setOperand(OtherIdx, isTrue ? It->second.first : It->second.second);
}
CBO->insertBefore(B->getTerminator()->getIterator());
return CBO;
Expand Down Expand Up @@ -1305,9 +1304,9 @@ bool SelectOptimizeImpl::computeLoopCosts(
auto UI = dyn_cast<Instruction>(U.get());
if (!UI)
continue;
if (InstCostMap.count(UI)) {
IPredCost = std::max(IPredCost, InstCostMap[UI].PredCost);
INonPredCost = std::max(INonPredCost, InstCostMap[UI].NonPredCost);
if (auto It = InstCostMap.find(UI); It != InstCostMap.end()) {
IPredCost = std::max(IPredCost, It->second.PredCost);
INonPredCost = std::max(INonPredCost, It->second.NonPredCost);
}
}
auto ILatency = computeInstCost(&I);
Expand Down Expand Up @@ -1338,8 +1337,8 @@ bool SelectOptimizeImpl::computeLoopCosts(

Scaled64 CondCost = Scaled64::getZero();
if (auto *CI = dyn_cast<Instruction>(SG->Condition))
if (InstCostMap.count(CI))
CondCost = InstCostMap[CI].NonPredCost;
if (auto It = InstCostMap.find(CI); It != InstCostMap.end())
CondCost = It->second.NonPredCost;
Scaled64 MispredictCost = getMispredictionCost(SI, CondCost);

INonPredCost = PredictedPathCost + MispredictCost;
Expand Down
Loading