Skip to content

[PowerPC] Use SelectionDAG::makeEquivalentMemoryOrdering(). NFC #124889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topperc merged 2 commits into from
Jan 29, 2025
Merged

[PowerPC] Use SelectionDAG::makeEquivalentMemoryOrdering(). NFC #124889

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28dd6d4
[PowerPC] Use SelectionDAG::makeEquivalentMemoryOrdering(). NFC
topperc Jan 29, 2025
756b2ce
fixup! remove helper
topperc Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions llvm/lib/Target/PowerPC/PPCISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8651,22 +8651,13 @@ bool PPCTargetLowering::canReuseLoadAddress(SDValue Op, EVT MemVT,
// Given the head of the old chain, ResChain, insert a token factor containing
// it and NewResChain, and make users of ResChain now be users of that token
// factor.
// TODO: Remove and use DAG::makeEquivalentMemoryOrdering() instead.
void PPCTargetLowering::spliceIntoChain(SDValue ResChain,
SDValue NewResChain,
SelectionDAG &DAG) const {
if (!ResChain)
return;

SDLoc dl(NewResChain);

SDValue TF = DAG.getNode(ISD::TokenFactor, dl, MVT::Other,
NewResChain, DAG.getUNDEF(MVT::Other));
assert(TF.getNode() != NewResChain.getNode() &&
"A new TF really is required here");

DAG.ReplaceAllUsesOfValueWith(ResChain, TF);
DAG.UpdateNodeOperands(TF.getNode(), ResChain, NewResChain);
DAG.makeEquivalentMemoryOrdering(ResChain, NewResChain);
Copy link
Contributor

@arsenm arsenm Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the TODO and remove the whole helper function?

Copy link
Collaborator Author

@topperc topperc Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but the null check on ResChain is needed for at least one of the 5 callers of this function. I'll look further to see how many really need it.

}

/// Analyze profitability of direct move
Expand Down