Skip to content

Conversation

@optimisan
Copy link
Contributor

@optimisan optimisan commented Jan 30, 2025

I saw that there used to be an overload operator<<(OS, const Pass &P).

Now that it's gone, I still don't find anyone using the print method except the internal debug printing hidden under LLVM_DEBUG in this function.

Copy link
Contributor Author

optimisan commented Jan 30, 2025

@llvmbot
Copy link
Member

llvmbot commented Jan 30, 2025

@llvm/pr-subscribers-llvm-regalloc

Author: Akshat Oke (optimisan)

Changes

I saw that there used to be an overload operator&lt;&lt;(OS, const Pass &amp;P).

Now that it's gone, I still don't find anyone using the print method except the internal debug printing hidden under LLVM_DEBUG in this function.


Full diff: https://github.com/llvm/llvm-project/pull/125042.diff

1 Files Affected:

  • (modified) llvm/lib/CodeGen/RegisterCoalescer.cpp (+1-8)
diff --git a/llvm/lib/CodeGen/RegisterCoalescer.cpp b/llvm/lib/CodeGen/RegisterCoalescer.cpp
index 62c15949e46dac..d2f7684ec83a48 100644
--- a/llvm/lib/CodeGen/RegisterCoalescer.cpp
+++ b/llvm/lib/CodeGen/RegisterCoalescer.cpp
@@ -390,9 +390,6 @@ class RegisterCoalescer : public MachineFunctionPass,
 
   /// This is the pass entry point.
   bool runOnMachineFunction(MachineFunction &) override;
-
-  /// Implement the dump method.
-  void print(raw_ostream &O, const Module * = nullptr) const override;
 };
 
 } // end anonymous namespace
@@ -4344,12 +4341,8 @@ bool RegisterCoalescer::runOnMachineFunction(MachineFunction &fn) {
   PHIValToPos.clear();
   RegToPHIIdx.clear();
 
-  LLVM_DEBUG(dump());
+  LLVM_DEBUG(LIS->dump());
   if (VerifyCoalescing)
     MF->verify(this, "After register coalescing", &errs());
   return true;
 }
-
-void RegisterCoalescer::print(raw_ostream &O, const Module *m) const {
-  LIS->print(O);
-}

@optimisan optimisan marked this pull request as ready for review January 30, 2025 11:26
@optimisan optimisan merged commit a5a2e2f into main Jan 31, 2025
12 checks passed
@optimisan optimisan deleted the users/Akshat-Oke/01-30-_codegen_registercoalescer_remove_the_print_method branch January 31, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants