Skip to content

Conversation

@llvmbot
Copy link
Member

@llvmbot llvmbot commented Jan 31, 2025

Backport e31c6c9

Requested by: @brad0

@llvmbot llvmbot added this to the LLVM 20.X Release milestone Jan 31, 2025
@llvmbot
Copy link
Member Author

llvmbot commented Jan 31, 2025

@vdonaldson What do you think about merging this PR to the release branch?

@llvmbot llvmbot requested a review from vdonaldson January 31, 2025 17:09
@llvmbot llvmbot added flang:runtime flang Flang issues not falling into any other category labels Jan 31, 2025
@llvmbot
Copy link
Member Author

llvmbot commented Jan 31, 2025

@llvm/pr-subscribers-flang-runtime

Author: None (llvmbot)

Changes

Backport e31c6c9

Requested by: @brad0


Full diff: https://github.com/llvm/llvm-project/pull/125254.diff

1 Files Affected:

  • (modified) flang/runtime/exceptions.cpp (+1-1)
diff --git a/flang/runtime/exceptions.cpp b/flang/runtime/exceptions.cpp
index b41c7cf438f569..114d23b5b07f8c 100644
--- a/flang/runtime/exceptions.cpp
+++ b/flang/runtime/exceptions.cpp
@@ -11,7 +11,7 @@
 #include "flang/Runtime/exceptions.h"
 #include "terminator.h"
 #include <cfenv>
-#if defined(__aarch64__) && !defined(_WIN32)
+#if defined(__aarch64__) && defined(__GLIBC__)
 #include <fpu_control.h>
 #elif defined(__x86_64__)
 #include <xmmintrin.h>

Copy link
Contributor

@vdonaldson vdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@llvmbot llvmbot force-pushed the issue125251 branch 2 times, most recently from 41692de to 58627ce Compare February 1, 2025 00:00
…m#125183)

The fpu_control.h header appears to be GLIBC specific.

(cherry picked from commit e31c6c9)
@tstellar tstellar merged commit c560d6f into llvm:release/20.x Feb 1, 2025
8 of 10 checks passed
@github-actions
Copy link

github-actions bot commented Feb 1, 2025

@brad0 (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:runtime flang Flang issues not falling into any other category

Projects

Development

Successfully merging this pull request may close these issues.

4 participants