Skip to content

[clang][CodeGenOpenCL][NFC] Remove redundant map lookups #125285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steakhal merged 1 commit into from
Feb 1, 2025
Merged

[clang][CodeGenOpenCL][NFC] Remove redundant map lookups #125285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions clang/lib/CodeGen/CGOpenCLRuntime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,11 @@ void CGOpenCLRuntime::recordBlockInfo(const BlockExpr *E,
assert(!EnqueuedBlockMap.contains(E) && "Block expression emitted twice");
assert(isa<llvm::Function>(InvokeF) && "Invalid invoke function");
assert(Block->getType()->isPointerTy() && "Invalid block literal type");
EnqueuedBlockMap[E].InvokeFunc = InvokeF;
EnqueuedBlockMap[E].BlockArg = Block;
EnqueuedBlockMap[E].BlockTy = BlockTy;
EnqueuedBlockMap[E].KernelHandle = nullptr;
EnqueuedBlockInfo &BlockInfo = EnqueuedBlockMap[E];
BlockInfo.InvokeFunc = InvokeF;
BlockInfo.BlockArg = Block;
BlockInfo.BlockTy = BlockTy;
BlockInfo.KernelHandle = nullptr;
}

llvm::Function *CGOpenCLRuntime::getInvokeFunction(const Expr *E) {
Expand All @@ -148,17 +149,19 @@ CGOpenCLRuntime::emitOpenCLEnqueuedBlock(CodeGenFunction &CGF, const Expr *E) {
// to get the block literal.
const BlockExpr *Block = getBlockExpr(E);

assert(EnqueuedBlockMap.contains(Block) && "Block expression not emitted");
auto It = EnqueuedBlockMap.find(Block);
assert(It != EnqueuedBlockMap.end() && "Block expression not emitted");
EnqueuedBlockInfo &BlockInfo = It->second;

// Do not emit the block wrapper again if it has been emitted.
if (EnqueuedBlockMap[Block].KernelHandle) {
return EnqueuedBlockMap[Block];
if (BlockInfo.KernelHandle) {
return BlockInfo;
}

auto *F = CGF.getTargetHooks().createEnqueuedBlockKernel(
CGF, EnqueuedBlockMap[Block].InvokeFunc, EnqueuedBlockMap[Block].BlockTy);
CGF, BlockInfo.InvokeFunc, BlockInfo.BlockTy);

// The common part of the post-processing of the kernel goes here.
EnqueuedBlockMap[Block].KernelHandle = F;
return EnqueuedBlockMap[Block];
BlockInfo.KernelHandle = F;
return BlockInfo;
}