Skip to content

[XRay][SystemZ] Use stckf for non-clang compilers #125289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

[XRay][SystemZ] Use stckf for non-clang compilers #125289

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f73b344
[XRay][SystemZ] Use stckf for non-clang compilers
redstar Jan 31, 2025
f157cbe
Address review comments.
redstar Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compiler-rt/lib/xray/xray_tsc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,13 @@ namespace __xray {
inline bool probeRequiredCPUFeatures() XRAY_NEVER_INSTRUMENT { return true; }

ALWAYS_INLINE uint64_t readTSC(uint8_t &CPU) XRAY_NEVER_INSTRUMENT {
#if defined(__clang__)
Copy link
Member

@MaskRay MaskRay Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__has_builtin(__builtin_readcyclecounter) ?

Copy link
Member Author

@redstar redstar Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

return __builtin_readcyclecounter();
#else
uint64_t Cycles;
asm volatile("stckf %0" : /* No output. */ : "Q"(Cycles) : "cc");
Copy link
Member

@MaskRay MaskRay Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the unnecessary comment /* No output. */. In the majority of places we assume that the user is aware of the : : syntax

Copy link
Member Author

@redstar redstar Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

return Cycles;
#endif
}

inline uint64_t getTSCFrequency() XRAY_NEVER_INSTRUMENT {
Expand Down