Skip to content

[CodeGen] Avoid repeated hash lookups (NFC) #125463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[CodeGen] Avoid repeated hash lookups (NFC) #125463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions llvm/include/llvm/CodeGen/LiveIntervals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,9 @@ class LiveIntervals {
LiveInterval &createEmptyInterval(Register Reg) {
assert(!hasInterval(Reg) && "Interval already exists!");
VirtRegIntervals.grow(Reg.id());
VirtRegIntervals[Reg.id()] = createInterval(Reg);
return *VirtRegIntervals[Reg.id()];
auto &Interval = VirtRegIntervals[Reg.id()];
Interval = createInterval(Reg);
return *Interval;
}

LiveInterval &createAndComputeVirtRegInterval(Register Reg) {
Expand All @@ -168,8 +169,9 @@ class LiveIntervals {

/// Interval removal.
void removeInterval(Register Reg) {
delete VirtRegIntervals[Reg];
VirtRegIntervals[Reg] = nullptr;
auto &Interval = VirtRegIntervals[Reg];
delete Interval;
Interval = nullptr;
}

/// Given a register and an instruction, adds a live segment from that
Expand Down