Skip to content

LAA: simplify LoopAccessInfoManager::clear (NFC) #125488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

LAA: simplify LoopAccessInfoManager::clear (NFC) #125488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c5cab7
LAA: use make_early_inc_range to simplify code (NFC)
artagnon Feb 3, 2025
7960105
LAA: strip make_early_inc_range
artagnon Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions llvm/lib/Analysis/LoopAccessAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3078,20 +3078,16 @@ const LoopAccessInfo &LoopAccessInfoManager::getInfo(Loop &L) {
return *It->second;
}
void LoopAccessInfoManager::clear() {
SmallVector<Loop *> ToRemove;
// Collect LoopAccessInfo entries that may keep references to IR outside the
// analyzed loop or SCEVs that may have been modified or invalidated. At the
// moment, that is loops requiring memory or SCEV runtime checks, as those cache
// SCEVs, e.g. for pointer expressions.
for (const auto &[L, LAI] : LoopAccessInfoMap) {
for (const auto &[L, LAI] : make_early_inc_range(LoopAccessInfoMap)) {
if (LAI->getRuntimePointerChecking()->getChecks().empty() &&
LAI->getPSE().getPredicate().isAlwaysTrue())
continue;
ToRemove.push_back(L);
}

for (Loop *L : ToRemove)
LoopAccessInfoMap.erase(L);
}
}

bool LoopAccessInfoManager::invalidate(
Expand Down