MachineUniformityAnalysis: Pass is incorrectly initialized as CFGOnly #125511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set CFGOnly in MachineUniformityAnalysisPass to false. If there were new registers created, uniformity analysis needs to be updated. Previously, with CFGOnly set to true, pass would be skipped if CFG was preserved.
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nhaehnle
approved these changes
Feb 3, 2025
Collaborator
nhaehnle
left a comment
nhaehnle
left a comment
There was a problem hiding this comment.
Thanks, LGTM! I wonder if there's a good way to test this, but I'm not sure. I don't think it's something we usually test.
Collaborator
Author
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…llvm#125511) Set CFGOnly in MachineUniformityAnalysisPass to false. If there were new registers created, uniformity analysis needs to be updated. Previously, with CFGOnly set to true, pass would be skipped if CFG was preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CFGOnly in MachineUniformityAnalysisPass to false.
If there were new registers created, uniformity analysis needs to be
updated. Previously, with CFGOnly set to true, pass would be skipped
if CFG was preserved.