Skip to content

Reland "[HLSL] Implement the reflect HLSL function" #125599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2025
Merged

Reland "[HLSL] Implement the reflect HLSL function" #125599

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff7e642
Reapply "Reland "[HLSL] Implement the `reflect` HLSL function"" (#124…
Icohedron Feb 3, 2025
ae25b96
Mark hwasan as unsupported
Icohedron Feb 10, 2025
b59d79d
Re-support hwasan. Replace /dev/null with -
Icohedron Feb 19, 2025
5fa99a1
Revert "Re-support hwasan. Replace /dev/null with -"
Icohedron Feb 24, 2025
b5d8eb1
Revert "Mark hwasan as unsupported"
Icohedron Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions llvm/test/CodeGen/SPIRV/opencl/reflect-error.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s
; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s
; UNSUPPORTED: hwasan
; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o - 2>&1 | FileCheck %s
Copy link
Collaborator

@vitalybuka vitalybuka Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this patch
https://github.com/llvm/llvm-project/pull/128386/files passes: https://lab.llvm.org/buildbot/#/builders/55/builds/7459

; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o - 2>&1 | FileCheck %s

; CHECK: LLVM ERROR: %{{.*}} = G_INTRINSIC intrinsic(@llvm.spv.reflect), %{{.*}}, %{{.*}} is only supported with the GLSL extended instruction set.

Expand Down