Skip to content

Conversation

@benshi001
Copy link
Member

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:static analyzer labels Feb 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 4, 2025

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-static-analyzer-1

Author: Ben Shi (benshi001)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/125622.diff

1 Files Affected:

  • (modified) clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h (+1-1)
diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
index f88bf70d72398c2..f8aa0f881b7ad3b 100644
--- a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
+++ b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
@@ -344,7 +344,7 @@ class GlobalImmutableSpaceRegion : public NonStaticGlobalSpaceRegion {
 };
 
 /// The region containing globals which can be modified by calls to
-/// "internally" defined functions - (for now just) functions other then system
+/// "internally" defined functions - (for now just) functions other than system
 /// calls.
 class GlobalInternalSpaceRegion : public NonStaticGlobalSpaceRegion {
   friend class MemRegionManager;

@benshi001 benshi001 requested a review from haoNoQ February 4, 2025 03:30
@steakhal
Copy link
Contributor

steakhal commented Feb 4, 2025

Does the "other then" pattern appear anywhere else?
Same for paremeters?

(At lesdt withing static analyzer code?)

Copy link
Contributor

@steakhal steakhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

@benshi001
Copy link
Member Author

Does the "other then" pattern appear anywhere else? Same for paremeters?

(At lesdt withing static analyzer code?)

I did not find them in other places.

@steakhal steakhal changed the title [clang][StaticAnalyzer] Fix a typo in comments [NFC] [clang][analyzer] Fix a typo in comments [NFC] Feb 4, 2025
@steakhal steakhal changed the title [clang][analyzer] Fix a typo in comments [NFC] [clang][analyzer][NFC] Fix a typo in comments Feb 4, 2025
@steakhal steakhal merged commit cde3c68 into llvm:main Feb 4, 2025
8 checks passed
@benshi001 benshi001 deleted the csa-typo branch February 5, 2025 00:46
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:static analyzer clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants