Skip to content

[webkit.UncountedLambdaCapturesChecker] Fix a bug that the checker didn't take the object pointer into account. #125662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[webkit.UncountedLambdaCapturesChecker] Fix a bug that the checker didn't take the object pointer into account. #125662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f44963f
[webkit.UncountedLambdaCapturesChecker] Fix a bug that the checker di…
rniwa Feb 4, 2025
052687a
Remove an extra blank line
rniwa Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,10 @@ class UncountedLambdaCapturesChecker
bool VisitCallExpr(CallExpr *CE) override {
checkCalleeLambda(CE);
if (auto *Callee = CE->getDirectCallee()) {
bool TreatAllArgsAsNoEscape = shouldTreatAllArgAsNoEscape(Callee);
unsigned ArgIndex = 0;
if (auto *CXXCallee = dyn_cast<CXXMethodDecl>(Callee))
ArgIndex = CXXCallee->isInstance();
bool TreatAllArgsAsNoEscape = shouldTreatAllArgAsNoEscape(Callee);
for (auto *Param : Callee->parameters()) {
if (ArgIndex >= CE->getNumArgs())
return true;
Expand Down
11 changes: 10 additions & 1 deletion clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,22 @@ struct RefCountableWithLambdaCapturingThis {
call(lambda);
}

void method_captures_this_with_guardian_refPtr() {
void method_captures_this_with_guardian_refptr() {
auto lambda = [this, protectedThis = RefPtr { &*this }]() {
nonTrivial();
};
call(lambda);
}

void forEach(const WTF::Function<void(RefCountable&)>&);
void method_captures_this_with_lambda_with_no_escape() {
auto run = [&]([[clang::noescape]] const WTF::Function<void(RefCountable&)>& func) {
forEach(func);
};
run([&](RefCountable&) {
nonTrivial();
});
}
};

struct NonRefCountableWithLambdaCapturingThis {
Expand Down