Skip to content

[OpenMP][flang][MLIR] Decouple alloc, init, and copy regions for omp.private|declare_reduction ops #125699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[OpenMP][flang][MLIR] Decouple alloc, init, and copy regions for omp.private|declare_reduction ops #125699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions flang/test/Integration/OpenMP/parallel-private-reduction-worstcase.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,46 +32,52 @@ subroutine worst_case(a, b, c, d)
! CHECK-LABEL: define internal void @worst_case_..omp_par
! CHECK-NEXT: omp.par.entry:
! [reduction alloc regions inlined here]
! CHECK: br label %omp.private.init
! CHECK: br label %omp.region.after_alloca

! CHECK: omp.private.init: ; preds = %omp.par.entry
! CHECK-NEXT: br label %omp.private.init7
! CHECK: omp.region.after_alloca:
! CHECK-NEXT: br label %omp.par.region

! CHECK: omp.par.region:
! CHECK-NEXT: br label %omp.private.init

! CHECK: omp.private.init:
! CHECK-NEXT: br label %omp.private.init2

! CHECK: omp.private.init7: ; preds = %omp.private.init
! CHECK: omp.private.init2:
! [begin private alloc for first var]
! [read the length from the mold argument]
! [if it is non-zero...]
! CHECK: br i1 {{.*}}, label %omp.private.init8, label %omp.private.init9
! CHECK: br i1 %{{.*}}, label %omp.private.init3, label %omp.private.init4

! CHECK: omp.private.init9: ; preds = %omp.private.init7
! [finish private alloc for first var with zero extent]
! CHECK: br label %omp.private.init10
! CHECK: omp.private.init4: ; preds = %omp.private.init2
! [finish private alloc for second var with zero extent]
! CHECK: br label %omp.private.init5

! CHECK: omp.private.init10: ; preds = %omp.private.init8, %omp.private.init9
! CHECK-NEXT: br label %omp.region.cont6
! CHECK: omp.private.init5: ; preds = %omp.private.init3, %omp.private.init4
! CHECK-NEXT: br label %omp.region.cont

! CHECK: omp.region.cont6: ; preds = %omp.private.init10
! CHECK: omp.region.cont: ; preds = %omp.private.init5
! CHECK-NEXT: %{{.*}} = phi ptr
! CHECK-NEXT: br label %omp.private.init1
! CHECK-NEXT: br label %omp.private.init7

! CHECK: omp.private.init1: ; preds = %omp.region.cont6
! CHECK: omp.private.init7:
! [begin private alloc for first var]
! [read the length from the mold argument]
! [if it is non-zero...]
! CHECK: br i1 %{{.*}}, label %omp.private.init2, label %omp.private.init3
! CHECK: br i1 {{.*}}, label %omp.private.init8, label %omp.private.init9

! CHECK: omp.private.init3: ; preds = %omp.private.init1
! [finish private alloc for second var with zero extent]
! CHECK: br label %omp.private.init4
! CHECK: omp.private.init9: ; preds = %omp.private.init7
! [finish private alloc for first var with zero extent]
! CHECK: br label %omp.private.init10

! CHECK: omp.private.init4: ; preds = %omp.private.init2, %omp.private.init3
! CHECK-NEXT: br label %omp.region.cont
! CHECK: omp.private.init10: ; preds = %omp.private.init8, %omp.private.init9
! CHECK-NEXT: br label %omp.region.cont6

! CHECK: omp.region.cont: ; preds = %omp.private.init4
! CHECK: omp.region.cont6: ; preds = %omp.private.init10
! CHECK-NEXT: %{{.*}} = phi ptr
! CHECK-NEXT: br label %omp.private.copy

! CHECK: omp.private.copy: ; preds = %omp.region.cont
! CHECK: omp.private.copy:
! CHECK-NEXT: br label %omp.private.copy12

! CHECK: omp.private.copy12: ; preds = %omp.private.copy
Expand All @@ -96,15 +102,9 @@ subroutine worst_case(a, b, c, d)

! CHECK: omp.region.cont15: ; preds = %omp.private.copy18
! CHECK-NEXT: %{{.*}} = phi ptr
! CHECK-NEXT: br label %omp.region.after_alloca

! CHECK: omp.region.after_alloca:
! CHECK-NEXT: br label %omp.par.region

! CHECK: omp.par.region: ; preds = %omp.region.after_alloca
! CHECK-NEXT: br label %omp.reduction.init

! CHECK: omp.reduction.init: ; preds = %omp.par.region
! CHECK: omp.reduction.init: ; preds = %omp.region.cont15
! [deffered stores for results of reduction alloc regions]
! CHECK: br label %[[VAL_96:.*]]

Expand Down Expand Up @@ -211,13 +211,13 @@ subroutine worst_case(a, b, c, d)
! [source length was non-zero: call assign runtime]
! CHECK: br label %omp.private.copy14

! CHECK: omp.private.init2: ; preds = %omp.private.init1
! [var extent was non-zero: malloc a private array]
! CHECK: br label %omp.private.init4

! CHECK: omp.private.init8: ; preds = %omp.private.init7
! [var extent was non-zero: malloc a private array]
! CHECK: br label %omp.private.init10

! CHECK: omp.private.init3: ; preds = %omp.private.init2
! [var extent was non-zero: malloc a private array]
! CHECK: br label %omp.private.init5

! CHECK: omp.par.outlined.exit.exitStub: ; preds = %omp.region.cont52
! CHECK-NEXT: ret void
Loading