release/20.x: [flang] Use clang_target_link_libraries() for clang dependency (#126037) #126062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@mgorny What do you think about merging this PR to the release branch? |
llvmbot
added
flang:driver
flang
Member
Author
|
@llvm/pr-subscribers-flang-driver Author: None (llvmbot) ChangesBackport 7c695e4 Requested by: @nikic Full diff: https://github.com/llvm/llvm-project/pull/126062.diff 1 Files Affected:
diff --git a/flang/unittests/Frontend/CMakeLists.txt b/flang/unittests/Frontend/CMakeLists.txt
index 9177997f41f53ac..2e3e7cb596c5802 100644
--- a/flang/unittests/Frontend/CMakeLists.txt
+++ b/flang/unittests/Frontend/CMakeLists.txt
@@ -12,7 +12,6 @@ add_flang_unittest(FlangFrontendTests
target_link_libraries(FlangFrontendTests
PRIVATE
- clangBasic
flangFrontend
flangFrontendTool
FortranLower
@@ -22,6 +21,11 @@ target_link_libraries(FlangFrontendTests
FortranEvaluate
)
+clang_target_link_libraries(FlangFrontendTests
+ PRIVATE
+ clangBasic
+)
+
mlir_target_link_libraries(FlangFrontendTests
PRIVATE
MLIRIR
|
mgorny
approved these changes
Feb 6, 2025
|
@nikic (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7c695e4
Requested by: @nikic