Skip to content

ValueTracking: modernize isKnownInversion (NFC) #126234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

ValueTracking: modernize isKnownInversion (NFC) #126234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions llvm/lib/Analysis/ValueTracking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8599,7 +8599,7 @@ bool llvm::isKnownInversion(const Value *X, const Value *Y) {
return false;

// They must both have samesign flag or not.
if (cast<ICmpInst>(X)->hasSameSign() != cast<ICmpInst>(Y)->hasSameSign())
if (Pred1.hasSameSign() != Pred2.hasSameSign())
return false;

if (B == C)
Expand All @@ -8611,8 +8611,7 @@ bool llvm::isKnownInversion(const Value *X, const Value *Y) {
return false;

// Sign bits of two RHSCs should match.
if (cast<ICmpInst>(X)->hasSameSign() &&
RHSC1->isNonNegative() != RHSC2->isNonNegative())
if (Pred1.hasSameSign() && RHSC1->isNonNegative() != RHSC2->isNonNegative())
return false;

const auto CR1 = ConstantRange::makeExactICmpRegion(Pred1, *RHSC1);
Expand Down