Skip to content

[libc] Use __builtin_elementwise_fma instead of __builtin_fma #126288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025
Merged

[libc] Use __builtin_elementwise_fma instead of __builtin_fma #126288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30fb1f9
[libc] Use __builtin_elementwise_fma instead of __builtin_fma
petrhosek Feb 7, 2025
32e599c
Check if __builtin_elementwise_fma is available
petrhosek Feb 7, 2025
ebb2660
Formatting fix
petrhosek Feb 7, 2025
83030b3
Use __builtin_fma for double
petrhosek Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libc/src/__support/FPUtil/FMA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,19 @@ LIBC_INLINE OutType fma(InType x, InType y, InType z) {

#ifdef LIBC_TARGET_CPU_HAS_FMA
template <> LIBC_INLINE float fma(float x, float y, float z) {
#if __has_builtin(__builtin_elementwise_fma)
return __builtin_elementwise_fma(x, y, z);
#else
return __builtin_fmaf(x, y, z);
#endif
}

template <> LIBC_INLINE double fma(double x, double y, double z) {
#if __has_builtin(__builtin_elementwise_fma)
return __builtin_elementwise_fma(x, y, z);
#else
return __builtin_fma(x, y, z);
#endif
}
#endif // LIBC_TARGET_CPU_HAS_FMA

Expand Down
8 changes: 8 additions & 0 deletions libc/src/__support/FPUtil/multiply_add.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,19 @@ namespace LIBC_NAMESPACE_DECL {
namespace fputil {

LIBC_INLINE float multiply_add(float x, float y, float z) {
#if __has_builtin(__builtin_elementwise_fma)
return __builtin_elementwise_fma(x, y, z);
#else
return __builtin_fmaf(x, y, z);
#endif
}

LIBC_INLINE double multiply_add(double x, double y, double z) {
#if __has_builtin(__builtin_elementwise_fma)
return __builtin_elementwise_fma(x, y, z);
#else
return __builtin_fma(x, y, z);
#endif
}

} // namespace fputil
Expand Down