Use precise types in DWARF BestForm methods #126309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that DIEInteger::BestForm used a cast to char:
if ((char)Int == SignedInt)
If 'char' happens to be unsigned, this will not behave correctly.
Then I also noticed that this code assumes the size of 'short' and
'int'.
This patch changes this code to use more precise types. No functional
change should be visible on ordinary hosts.
Contributor
Author
|
@dwblaikie this is another DWARF-related patch that didn't get properly labelled by the bot. |
dwblaikie
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that DIEInteger::BestForm used a cast to char:
If 'char' happens to be unsigned, this will not behave correctly. Then I also noticed that this code assumes the size of 'short' and 'int'.
This patch changes this code to use more precise types. No functional change should be visible on ordinary hosts.