Skip to content

[llvm][ELF]Add Shdr check for getBuildID #126537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 3, 2025
Merged

[llvm][ELF]Add Shdr check for getBuildID #126537

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a19e1a0
[llvm-objdump][ELF]Add Shdr buildID check(#126418)
cabbaken Feb 10, 2025
20f7214
Merge branch 'main' into 126418
cabbaken Feb 11, 2025
169f9db
[LLVM][ELF]Add Align check for getDesc()
cabbaken Feb 11, 2025
0c6d355
Optimize getBuildID() code style
cabbaken Feb 12, 2025
7105db4
Merge branch 'main' into 126418
cabbaken Feb 12, 2025
40ff1ff
Fix alignment judge of getDesc()
cabbaken Feb 13, 2025
0a502cd
Add AddressAlign to symbolize-build-id.test to
cabbaken Feb 13, 2025
7193339
Optimize code style.
cabbaken Feb 13, 2025
c388efa
remove unneeded empty check
cabbaken Feb 13, 2025
9393e97
Add invalid filesz of program header(PT_NOTE)
cabbaken Feb 14, 2025
e07a49b
add unit test of getBuildId()
cabbaken Feb 21, 2025
4e83f8a
add test cases for BuildIDTest.
cabbaken Feb 25, 2025
2e8c6ba
add InvalidSectionHeaderTest, modify name of test in BuildIDTest.cpp
Mar 6, 2025
6fa8919
Merge branch 'main' into 126418
cabbaken Sep 18, 2025
b64f287
Fix uint64_t overflow detect.
cabbaken Sep 22, 2025
fece101
Update llvm/unittests/Object/BuildIDTest.cpp
cabbaken Sep 22, 2025
a1971c9
Fix boundary value and comment style
cabbaken Sep 30, 2025
62ee98b
Merge branch 'main' into 126418
cabbaken Sep 30, 2025
47b96a1
Merge branch 'main' into 126418
cabbaken Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/Object/ELFTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ class Elf_Note_Impl {

/// Get the note's descriptor.
ArrayRef<uint8_t> getDesc(size_t Align) const {
if (!Nhdr.n_descsz)
if (!Nhdr.n_descsz || !Align)
return ArrayRef<uint8_t>();
return ArrayRef<uint8_t>(
reinterpret_cast<const uint8_t *>(&Nhdr) +
Expand Down
14 changes: 14 additions & 0 deletions llvm/lib/Object/BuildID.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ using namespace llvm::object;
namespace {

template <typename ELFT> BuildIDRef getBuildID(const ELFFile<ELFT> &Obj) {
auto Sections = cantFail(Obj.sections());
if (!Sections.empty()) {
for (const auto &S : Sections) {
if (S.sh_type != ELF::SHT_NOTE)
continue;
Error Err = Error::success();
for (auto N : Obj.notes(S, Err))
if (N.getType() == ELF::NT_GNU_BUILD_ID &&
N.getName() == ELF::ELF_NOTE_GNU)
return N.getDesc(S.sh_addralign);
consumeError(std::move(Err));
}
}

auto PhdrsOrErr = Obj.program_headers();
if (!PhdrsOrErr) {
consumeError(PhdrsOrErr.takeError());
Expand Down